Browse Source

modemdvb: Fix negative shift in cell interleaver

Fix Coverity CID 657550 by avoiding the shift when m_nd is
zero. The previous expression could shift by -1, causing
undefined behavior.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.1.0
Robin Getz 4 weeks ago
parent
commit
154e76b045
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 2
      modemdvb/dvbt2fec.cpp

2
modemdvb/dvbt2fec.cpp

@ -951,7 +951,7 @@ CellInterleaver::CellInterleaver(int ncells) : @@ -951,7 +951,7 @@ CellInterleaver::CellInterleaver(int ncells) :
r = (r >> 1) | (bit << (m_nd - 2));
}
int value = (int) (((i & 1) << (m_nd - 1)) | r);
int value = m_nd > 0 ? (int) (((i & 1) << (m_nd - 1)) | r) : (int) r;
if (value < ncells) {
m_l0[q++] = value;

Loading…
Cancel
Save