Browse Source

demodft8: Prevent unsafe copying of FT8DemodSink

Explicitly delete the copy constructor and copy assignment operator for
FT8DemodSink, which manages resources that should not be shared through
implicit shallow copies.

The implicitly generated copy operations could leave multiple FT8DemodSink
instances referring to the same resources, potentially causing invalid
ownership or double deletion.

Since FT8DemodSink is not intended to be copied or assigned, prohibit both
operations at compile time, turning potential runtime errors into
compile-time errors.

cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 1 month ago
parent
commit
192c87b7cd
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 4
      plugins/channelrx/demodft8/ft8demodsink.h

4
plugins/channelrx/demodft8/ft8demodsink.h

@ -35,7 +35,9 @@ class FT8Buffer; @@ -35,7 +35,9 @@ class FT8Buffer;
class FT8DemodSink : public ChannelSampleSink {
public:
FT8DemodSink();
~FT8DemodSink();
~FT8DemodSink();
FT8DemodSink(const FT8DemodSink&) = delete;
FT8DemodSink& operator=(const FT8DemodSink&) = delete;
virtual void feed(const SampleVector::const_iterator& begin, const SampleVector::const_iterator& end);

Loading…
Cancel
Save