From cc8bbac4a43f535dbda21c882afc1d0a47e8d9a1 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Wed, 14 Oct 2026 19:01:16 -0400 Subject: [PATCH 1/8] test_psk31: Fix signedness warning in sample loop Resolve GCC -Wsign-compare by matching the loop index type to the unsigned size returned by the container. This avoids signed/unsigned comparison errors and potential incorrect loop bounds when processing sample buffers. Signed-off-by: Robin Getz --- sdrbench/test_psk31.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdrbench/test_psk31.cpp b/sdrbench/test_psk31.cpp index 5e529603d..7fa306aa9 100644 --- a/sdrbench/test_psk31.cpp +++ b/sdrbench/test_psk31.cpp @@ -338,7 +338,7 @@ QString runChannelTrial( } constexpr int blockSize = 1000; - for (int i = 0; i < samples.size(); i += blockSize) { + for (std::size_t i = 0; i < samples.size(); i += blockSize) { demod.feed(samples.begin() + i, samples.begin() + std::min(i + blockSize, samples.size())); } From 5499368d4bcac4d1e9b83f9e9f9cb827007873c9 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Wed, 14 Oct 2026 19:03:13 -0400 Subject: [PATCH 2/8] plugins/denoiser: Initialize VST3 component handler callback Resolve GCC -Wmissing-field-initializers by explicitly initializing the onEdit callback to an empty std::function. This ensures the callback starts in a defined empty state and avoids relying on implicit aggregate initialization behavior. Signed-off-by: Robin Getz --- plugins/feature/denoiser/vst3effect.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/feature/denoiser/vst3effect.cpp b/plugins/feature/denoiser/vst3effect.cpp index 103f98861..987fef13b 100644 --- a/plugins/feature/denoiser/vst3effect.cpp +++ b/plugins/feature/denoiser/vst3effect.cpp @@ -568,7 +568,7 @@ struct Vst3Effect::Impl { Module module; QByteArray classId; - ComponentHandler handler = {{&handlerVtbl}, {}}; + ComponentHandler handler = {{&handlerVtbl}, {}, {}}; std::function detachEditor; Steinberg_Vst_IComponent *component = nullptr; Steinberg_Vst_IAudioProcessor *processor = nullptr; From f157ecf7ae5788bcb0ccdf36e13ff973013770a4 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Wed, 14 Oct 2026 19:04:05 -0400 Subject: [PATCH 3/8] demodwefax: Mark unused acquisition frequency parameter Resolve the compiler warning for the unused frequencyHz parameter in processAcquisitionSample(). Use Q_UNUSED to explicitly document that the parameter is intentionally unused without changing behavior. Signed-off-by: Robin Getz --- plugins/channelrx/demodwefax/wefaxdemodsink.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/channelrx/demodwefax/wefaxdemodsink.cpp b/plugins/channelrx/demodwefax/wefaxdemodsink.cpp index 29b62cfc5..cd51d5ea6 100644 --- a/plugins/channelrx/demodwefax/wefaxdemodsink.cpp +++ b/plugins/channelrx/demodwefax/wefaxdemodsink.cpp @@ -347,6 +347,7 @@ void WefaxDemodSink::processOneSample(const Complex& sample) void WefaxDemodSink::processAcquisitionSample(float video, float frequencyHz, double magnitudeSquared) { + Q_UNUSED(frequencyHz); const WefaxDecoder::State state = m_decoder.state(); ++m_acquisitionSampleCount; From 50d0cf9b49a56d3edb429dbae397a7199e70fef7 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Wed, 14 Oct 2026 19:04:58 -0400 Subject: [PATCH 4/8] modemdvb: Remove unused DVB-T2 constellation variable Remove the unused eta variable in Receiver::decodeFrame(). The value returned by bitsPerCell() was never used, so its calculation is unnecessary and removing it eliminates the unused-variable compiler warning without changing behavior. Signed-off-by: Robin Getz --- modemdvb/dvbt2receiver.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/modemdvb/dvbt2receiver.cpp b/modemdvb/dvbt2receiver.cpp index 45614801f..59f17e31b 100644 --- a/modemdvb/dvbt2receiver.cpp +++ b/modemdvb/dvbt2receiver.cpp @@ -946,7 +946,6 @@ void Receiver::decodeFrame(InterleavingFrame& frame, FEC& fec, Turn& turn) } const int ncells = cellsPerFECBlock(plp.m_fecType, plp.m_constellation); - const int eta = bitsPerCell(plp.m_constellation); const int nblocks = plp.m_numBlocks; const bool ti = plp.m_timeIlLength > 0; const int nti = ti ? plp.tiBlocks() : nblocks; // Without time interleaving, each FEC block is on its own From fb50e31395b2369086115d2a80b89efd055a0dd4 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Wed, 14 Oct 2026 19:05:53 -0400 Subject: [PATCH 5/8] devices/usrp: Move properties into tick-rate restore guard Use std::move when initializing the restoreAutoTickRate guard to avoid an unnecessary copy of properties. Include utility explicitly for std::move and make ownership transfer intent clear, reducing overhead during USRP device initialization. Signed-off-by: Robin Getz --- devices/usrp/deviceusrpparam.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/devices/usrp/deviceusrpparam.cpp b/devices/usrp/deviceusrpparam.cpp index 2fb2ab337..e21396c7f 100644 --- a/devices/usrp/deviceusrpparam.cpp +++ b/devices/usrp/deviceusrpparam.cpp @@ -17,6 +17,7 @@ /////////////////////////////////////////////////////////////////////////////////// #include +#include #include #include "deviceusrpparam.h" @@ -132,7 +133,7 @@ bool DeviceUSRPParams::open(const QString &deviceStr, bool channelNumOnly) } catch (...) { } } - } restoreAutoTickRate{properties, autoTickRatePath}; + } restoreAutoTickRate{std::move(properties), autoTickRatePath}; // Find max and min sample rate, for max and min master clock rates m_dev->set_master_clock_rate(clockRange.start()); From 3abfa021a37f7a1c267e3db9be6940a6507d5a40 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Wed, 14 Oct 2026 19:06:47 -0400 Subject: [PATCH 6/8] devices/usrp: Pass master clock rate handle by const reference Avoid copying the UHD shared-pointer handle when enabling automatic master clock rate selection. Passing the handle by const reference reduces unnecessary reference-count operations while preserving access to the underlying USRP device. Signed-off-by: Robin Getz --- devices/usrp/deviceusrp.cpp | 2 +- devices/usrp/deviceusrp.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/devices/usrp/deviceusrp.cpp b/devices/usrp/deviceusrp.cpp index 0887fcc7d..537652dab 100644 --- a/devices/usrp/deviceusrp.cpp +++ b/devices/usrp/deviceusrp.cpp @@ -283,7 +283,7 @@ bool DeviceUSRP::setMasterClockRateForSampleRate(uhd::usrp::multi_usrp::sptr usr return true; } -void DeviceUSRP::enableAutoMasterClockRate(uhd::usrp::multi_usrp::sptr usrp) +void DeviceUSRP::enableAutoMasterClockRate(const uhd::usrp::multi_usrp::sptr& usrp) { usrp->get_device()->get_tree()->access("/mboards/0/auto_tick_rate").set(true); } diff --git a/devices/usrp/deviceusrp.h b/devices/usrp/deviceusrp.h index b345e72e0..b1de216af 100644 --- a/devices/usrp/deviceusrp.h +++ b/devices/usrp/deviceusrp.h @@ -56,7 +56,7 @@ public: * Returns true if automatic selection should be re-enabled with enableAutoMasterClockRate() once the sample rates have been set. */ static bool setMasterClockRateForSampleRate(uhd::usrp::multi_usrp::sptr usrp, double sampleRate, size_t nbChannels); - static void enableAutoMasterClockRate(uhd::usrp::multi_usrp::sptr usrp); + static void enableAutoMasterClockRate(const uhd::usrp::multi_usrp::sptr& usrp); /** * Set sample rate of a single channel. If it can't be achieved with a master clock rate UHD chooses automatically From 27dfe09bb86299a5bca347e4c86eef2936781c86 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Wed, 14 Oct 2026 19:25:07 -0400 Subject: [PATCH 7/8] demoddrm: Remove redundant reverse API port bounds Resolve GCC -Wtype-limits warnings by removing upper-bound comparisons that are always true or false for uint16_t. The port's type already enforces the maximum value of 65535; validation of wider input values remains in place before casting. Signed-off-by: Robin Getz --- plugins/channelrx/demoddrm/drmdemodsettings.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/channelrx/demoddrm/drmdemodsettings.cpp b/plugins/channelrx/demoddrm/drmdemodsettings.cpp index 2654e7c70..fc5940177 100644 --- a/plugins/channelrx/demoddrm/drmdemodsettings.cpp +++ b/plugins/channelrx/demoddrm/drmdemodsettings.cpp @@ -106,7 +106,7 @@ void DRMDemodSettings::sanitize() m_volume = std::clamp(m_volume, 0.0f, 10.0f); m_streamIndex = std::max(m_streamIndex, 0); - if (m_reverseAPIPort <= 1023 || m_reverseAPIPort > 65535) { + if (m_reverseAPIPort <= 1023) { m_reverseAPIPort = 8888; } @@ -261,7 +261,7 @@ void DRMDemodSettings::applySettings(const QStringList& settingsKeys, const DRMD } if (settingsKeys.contains("reverseAPIPort")) { - m_reverseAPIPort = settings.m_reverseAPIPort > 1023 && settings.m_reverseAPIPort < 65536 + m_reverseAPIPort = settings.m_reverseAPIPort > 1023 ? settings.m_reverseAPIPort : 8888; } if (settingsKeys.contains("reverseAPIDeviceIndex")) { From 69256c11d1edfe2add9bc39dc36f0e25f3d04c91 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Wed, 14 Oct 2026 19:28:18 -0400 Subject: [PATCH 8/8] demoddvb: Fix member initialization order Resolve GCC -Wreorder by moving m_spectrumBinHz before m_autoUnlockedSamples in the constructor initializer list to match declaration order in the header. C++ initializes members in declaration order regardless of initializer list order, so keeping the list aligned avoids misleading initialization sequences and helps prevent future initialization bugs. Signed-off-by: Robin Getz --- plugins/channelrx/demoddvb/dvbdemodsink.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/channelrx/demoddvb/dvbdemodsink.cpp b/plugins/channelrx/demoddvb/dvbdemodsink.cpp index ea82921fd..56964c0df 100644 --- a/plugins/channelrx/demoddvb/dvbdemodsink.cpp +++ b/plugins/channelrx/demoddvb/dvbdemodsink.cpp @@ -206,11 +206,11 @@ DVBDemodSink::DVBDemodSink() : m_active(0), m_unlockedSamples(0), m_autoRate(0.0), - m_autoUnlockedSamples(0), m_spectrumBinHz(0.0), m_minSignalWidth(0.0), m_rateSearches(0), m_bandGeneration(0), + m_autoUnlockedSamples(0), m_s2GoodFrames(0), m_sGoodPackets(0), m_ncoShift(false),