From 1f93fa6fc84f9bc592cdcd40c68ed136ace993be Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Sun, 25 Oct 2026 14:33:57 -0400 Subject: [PATCH] modemdvb: Validate constellation in InnerDecoder::configure Reject invalid constellation values before configuring decoder state or calculating bit-interleaver sizes and indices. This prevents invalid bits-per-cell values from causing invalid vector sizes and out-of-bounds accesses. Coverity CIDs 657500 and 657487. Signed-off-by: Robin Getz --- modemdvb/dvbtinner.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/modemdvb/dvbtinner.cpp b/modemdvb/dvbtinner.cpp index 1c111ebfe..ed27c944d 100644 --- a/modemdvb/dvbtinner.cpp +++ b/modemdvb/dvbtinner.cpp @@ -18,6 +18,7 @@ #include #include +#include #include "dvbtinner.h" @@ -88,6 +89,18 @@ float InnerDecoder::normalisation(Constellation constellation, Hierarchy hierarc void InnerDecoder::configure(Mode mode, Constellation constellation, CodeRate codeRate, Hierarchy hierarchy, bool lowPriority) { + switch (constellation) + { + case Constellation::QPSK: + case Constellation::QAM16: + case Constellation::QAM64: + break; + default: + qWarning() << "InnerDecoder::configure: Invalid constellation" + << static_cast(constellation); + return; + } + const Tables& tables = Tables::get(mode); m_mode = mode;