From 27dfe09bb86299a5bca347e4c86eef2936781c86 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Wed, 14 Oct 2026 19:25:07 -0400 Subject: [PATCH] demoddrm: Remove redundant reverse API port bounds Resolve GCC -Wtype-limits warnings by removing upper-bound comparisons that are always true or false for uint16_t. The port's type already enforces the maximum value of 65535; validation of wider input values remains in place before casting. Signed-off-by: Robin Getz --- plugins/channelrx/demoddrm/drmdemodsettings.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/channelrx/demoddrm/drmdemodsettings.cpp b/plugins/channelrx/demoddrm/drmdemodsettings.cpp index 2654e7c70..fc5940177 100644 --- a/plugins/channelrx/demoddrm/drmdemodsettings.cpp +++ b/plugins/channelrx/demoddrm/drmdemodsettings.cpp @@ -106,7 +106,7 @@ void DRMDemodSettings::sanitize() m_volume = std::clamp(m_volume, 0.0f, 10.0f); m_streamIndex = std::max(m_streamIndex, 0); - if (m_reverseAPIPort <= 1023 || m_reverseAPIPort > 65535) { + if (m_reverseAPIPort <= 1023) { m_reverseAPIPort = 8888; } @@ -261,7 +261,7 @@ void DRMDemodSettings::applySettings(const QStringList& settingsKeys, const DRMD } if (settingsKeys.contains("reverseAPIPort")) { - m_reverseAPIPort = settings.m_reverseAPIPort > 1023 && settings.m_reverseAPIPort < 65536 + m_reverseAPIPort = settings.m_reverseAPIPort > 1023 ? settings.m_reverseAPIPort : 8888; } if (settingsKeys.contains("reverseAPIDeviceIndex")) {