Browse Source

util: Prevent unsafe copying of DoubleBufferFIFO

Explicitly delete the copy constructor and copy assignment operator for
DoubleBufferFIFO to prevent accidental duplication of its data buffer.

The destructor deletes m_data with delete[]. A shallow copy would cause
multiple instances to own the same buffer, potentially resulting in
double deletion and memory corruption.

Since DoubleBufferFIFO manages its buffer directly, prohibit copying and
assignment at compile time.

cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 1 month ago
parent
commit
31ee803659
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 3
      sdrbase/util/doublebufferfifo.h

3
sdrbase/util/doublebufferfifo.h

@ -35,6 +35,9 @@ public: @@ -35,6 +35,9 @@ public:
delete[] m_data;
}
DoubleBufferFIFO(const DoubleBufferFIFO&) = delete;
DoubleBufferFIFO& operator=(const DoubleBufferFIFO&) = delete;
void resize(int size)
{
delete[] m_data;

Loading…
Cancel
Save