From 3a4a6fb87a2fae66dfb458fd121d72985d2ac3dc Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Sun, 25 Oct 2026 14:29:33 -0400 Subject: [PATCH] dvbs2: Validate BCH information length before deframing Reject non-positive BCH information lengths before scrambling or decoding the frame, and log a warning with the invalid value. Coverity CID 657505 identified a potential negative length passed to scrambleBytes(). Signed-off-by: Robin Getz --- modemdvb/dvbs2receiver.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/modemdvb/dvbs2receiver.cpp b/modemdvb/dvbs2receiver.cpp index 3bacecaa0..d81492e10 100644 --- a/modemdvb/dvbs2receiver.cpp +++ b/modemdvb/dvbs2receiver.cpp @@ -20,6 +20,7 @@ #include #include #include +#include #include "util/profiler.h" #include "dvbs2receiver.h" @@ -892,6 +893,10 @@ void Receiver::deframe(FrameSlot& slot) { const XFECFrame& frame = slot.m_frame; const int kbch = frame.m_vlsnr >= 0 ? vlsnrKbch(frame.m_vlsnr) : dvbt2::kbch(frame.m_fecType, frame.m_rate, CodeFamily::S2); + if (kbch <= 0) { + qWarning() << "Receiver::deframe: Invalid BCH information length" << kbch; + return; + } const bool bad = slot.m_corrected < 0; dvbt2::scrambleBytes(slot.m_packed.data(), kbch / 8); dvbt2::BBFrameDecoder::Header header;