From 3f4a948595d435a71684034de2eeb99aeff6e4fc Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Wed, 16 Sep 2026 07:39:20 -0400 Subject: [PATCH] wsspectrum: Avoid overwriting existing WebSocket server Check for an existing QWebSocketServer before creating a new one. Leave an already-listening server untouched and clean up an existing non-listening server before replacing it. This resolves the cppcheck possible leak warning caused by overwriting m_webSocketServer without deallocating the previous object. Signed-off-by: Robin Getz --- sdrbase/websockets/wsspectrum.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sdrbase/websockets/wsspectrum.cpp b/sdrbase/websockets/wsspectrum.cpp index ca69b99c7..a92a4dae0 100644 --- a/sdrbase/websockets/wsspectrum.cpp +++ b/sdrbase/websockets/wsspectrum.cpp @@ -47,6 +47,17 @@ WSSpectrum::~WSSpectrum() void WSSpectrum::openSocket() { + if (m_webSocketServer) + { + if (m_webSocketServer->isListening()) + { + qDebug() << "WSSpectrum::openSocket: invoked while spectrum server already listening at " + << m_listeningAddress.toString() << " on port " << m_port; + return; + } + closeSocket(); + } + m_webSocketServer = new QWebSocketServer( QStringLiteral("Spectrum Server"), QWebSocketServer::NonSecureMode,