Browse Source

morsedemod : Initialize MorseDemod members

Initialize MorseDemod state and message queue members so a newly constructed
demodulator has defined values before identification and bit timing
processing begins. This prevents undefined behavior from accessing
uninitialized member variables.

Found by cppcheck (uninitMemberVar).

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 2 months ago
parent
commit
50caef61f8
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 10
      sdrbase/dsp/morsedemod.cpp

10
sdrbase/dsp/morsedemod.cpp

@ -24,9 +24,17 @@ @@ -24,9 +24,17 @@
MESSAGE_CLASS_DEFINITION(MorseDemod::MsgReportIdent, Message)
MorseDemod::MorseDemod() :
m_messageQueueToChannel(nullptr),
m_movingAverageIdent(5000),
m_identMaxs{},
m_identNoise(0.0),
m_binSampleCnt(0),
m_binCnt(0),
m_samplesPerDot7wpm(0),
m_samplesPerDot10wpm(0),
m_prevBit(0),
m_bitTime(0)
m_bitTime(0),
m_identThreshold(0)
{
}

Loading…
Cancel
Save