Browse Source

qrtplib: Prevent unsafe copying of RTPRawPacket

Explicitly delete the copy constructor and copy assignment operator for
RTPRawPacket, which represents a received packet and manages resources
that should not be duplicated through implicit shallow copies.

The implicitly generated copy operations could duplicate internal pointers,
leaving multiple RTPRawPacket instances referring to the same resources
and potentially causing invalid ownership or double deletion.

Since RTPRawPacket is not intended to be copied or assigned, prohibit both
operations at compile time to prevent unsafe resource ownership.

cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 1 month ago
parent
commit
5155e9e8f3
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 2
      qrtplib/rtprawpacket.h

2
qrtplib/rtprawpacket.h

@ -58,6 +58,8 @@ public: @@ -58,6 +58,8 @@ public:
*/
RTPRawPacket(const uint8_t *data, std::size_t datalen, const RTPAddress& address, RTPTime &recvtime, bool rtp);
~RTPRawPacket();
RTPRawPacket(const RTPRawPacket&) = delete;
RTPRawPacket& operator=(const RTPRawPacket&) = delete;
/** Returns the pointer to the data which is contained in this packet. */
uint8_t *GetData()

Loading…
Cancel
Save