Browse Source

demodbfm: Prevent unsafe copying of BFMDemodSink

Explicitly delete the copy constructor and copy assignment operator for
BFMDemodSink, which manages resources that should not be shared through
implicit shallow copies.

The implicitly generated copy operations could leave multiple BFMDemodSink
instances referring to the same resources, potentially causing invalid
ownership or double deletion.

Since BFMDemodSink is not intended to be copied or assigned, prohibit both
operations at compile time, turning potential runtime errors into
compile-time errors.

cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 1 month ago
parent
commit
5881aed035
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 4
      plugins/channelrx/demodbfm/bfmdemodsink.h

4
plugins/channelrx/demodbfm/bfmdemodsink.h

@ -44,7 +44,9 @@ class BasebandSampleSink; @@ -44,7 +44,9 @@ class BasebandSampleSink;
class BFMDemodSink : public ChannelSampleSink {
public:
BFMDemodSink();
~BFMDemodSink();
~BFMDemodSink();
BFMDemodSink(const BFMDemodSink&) = delete;
BFMDemodSink& operator=(const BFMDemodSink&) = delete;
virtual void feed(const SampleVector::const_iterator& begin, const SampleVector::const_iterator& end);

Loading…
Cancel
Save