From 621ba92eb5cdf478dc38130e0842c8a1f43868dd Mon Sep 17 00:00:00 2001 From: Jon Beniston Date: Thu, 29 Oct 2026 21:03:01 +0000 Subject: [PATCH] Speed up ACARS demod GUI, as there can be many of them. --- .../channelrx/demodacars/acarsdemodgui.cpp | 68 ++- plugins/channelrx/demodacars/acarsdemodgui.h | 488 +++++++++--------- 2 files changed, 286 insertions(+), 270 deletions(-) diff --git a/plugins/channelrx/demodacars/acarsdemodgui.cpp b/plugins/channelrx/demodacars/acarsdemodgui.cpp index de3c7ec71..90dd7f533 100644 --- a/plugins/channelrx/demodacars/acarsdemodgui.cpp +++ b/plugins/channelrx/demodacars/acarsdemodgui.cpp @@ -244,7 +244,7 @@ void AcarsDemodGUI::sendGroundStationToMap(const QString& name, float latitude, swgMapItem->setLatitude(latitude); swgMapItem->setLongitude(longitude); swgMapItem->setAltitude(0.0f); - swgMapItem->setPositionDateTime(new QString(dateTime.toString(Qt::ISODateWithMs))); + swgMapItem->setPositionDateTime(new QString(dateTime.toUTC().toString(Qt::ISODateWithMs))); swgMapItem->setFixedPosition(true); // The Map feature's antenna icon, as used for its own beacons swgMapItem->setImage(new QString(QString("qrc:///map/map/antenna.png"))); @@ -265,7 +265,7 @@ void AcarsDemodGUI::rowReady(const AcarsRowEvent& e) m_frameRateCount[e.m_frameType]++; } if (!e.m_chartAircraftId.isEmpty()) { - m_aircraftLastSeen.insert(e.m_chartAircraftId, e.m_received); + m_aircraftLastSeen.insert(e.m_chartAircraftId, e.m_received.toMSecsSinceEpoch()); } // HFDL ground stations heard, for the ground stations dialog @@ -865,6 +865,17 @@ void AcarsDemodGUI::onMenuDialogCalled(const QPoint &p) resetContextMenuType(); } +// Every demodulator's tick() hangs off the one master timer, so work done on a fixed tick +// count - the chart update once a second, the averaging once a minute - landed in the same +// timer event for all of them, and with 25 demodulators that added up to a 40-65 ms GUI +// stall once a second. Starting each count somewhere different puts each demodulator's +// share of that work in a different timer event +static uint32_t staggeredTickStart() +{ + static uint32_t next = 0; // Only ever used on the GUI thread + return next++; +} + AcarsDemodGUI::AcarsDemodGUI(PluginAPI* pluginAPI, DeviceUISet *deviceUISet, BasebandSampleSink *rxChannel, QWidget* parent) : ChannelGUI(parent), ui(new Ui::AcarsDemodGUI), @@ -874,7 +885,7 @@ AcarsDemodGUI::AcarsDemodGUI(PluginAPI* pluginAPI, DeviceUISet *deviceUISet, Bas m_doApplySettings(true), m_deviceCenterFrequency(0), m_basebandSampleRate(1), - m_tickCount(0), + m_tickCount(staggeredTickStart()), m_progressDialog(nullptr), m_tableTimer(nullptr), m_scrollPending(false), @@ -884,7 +895,7 @@ AcarsDemodGUI::AcarsDemodGUI(PluginAPI* pluginAPI, DeviceUISet *deviceUISet, Bas m_fpsYAxis(nullptr), m_aircraftYAxis(nullptr), - m_frameRateTime(QDateTime::currentDateTime()), + m_frameRateTime(QDateTime::currentDateTimeUtc()), m_chartPanning(false) { setAttribute(Qt::WA_DeleteOnClose, true); @@ -1012,18 +1023,7 @@ AcarsDemodGUI::AcarsDemodGUI(PluginAPI* pluginAPI, DeviceUISet *deviceUISet, Bas ui->scopeContainer->setVisible(false); - // Add airport acronyms to decoder as tool tips - QSharedPointer> airportsByIdent = OurAirportsDB::getAirportsByIdent(); - if (airportsByIdent) - { - QHashIterator itr(*airportsByIdent); - while (itr.hasNext()) - { - itr.next(); - const AirportInformation *info = itr.value(); - ui->decode->addAcronym(info->m_ident, info->m_name); - } - } + // Airport idents in the decode get their names as tooltips from AcarsMessageView itself AircraftInformation::init(); connect(&m_osnDB, &OsnDB::downloadingURL, this, &AcarsDemodGUI::downloadingURL); @@ -1371,13 +1371,17 @@ void AcarsDemodGUI::tick() (100.0f + powDbPeak) / 100.0f, nbMagsqSamples); - if (m_tickCount % 4 == 0) { - ui->channelPower->setText(QString::number(powDbAvg, 'f', 1)); + // Only update labels that can be seen, to avoid unncessary compositing + if (m_tickCount % 4 == 0) + { + if (!ui->channelPower->visibleRegion().isEmpty()) { + ui->channelPower->setText(QString::number(powDbAvg, 'f', 1)); + } // Aero is the one protocol with a continuous carrier to measure, so it is the only // one where a live quality figure means anything. A burst mode would be showing // whatever the last burst happened to look like. - if (m_settings.m_mode == AcarsDemodSettings::Aero) + if ((m_settings.m_mode == AcarsDemodSettings::Aero) && !ui->quality->visibleRegion().isEmpty()) { double evm, suRate; m_acarsDemod->getAeroQuality(evm, suRate); @@ -1396,7 +1400,10 @@ void AcarsDemodGUI::tick() const int ticksPerSecond = 20; if ((m_tickCount % ticksPerSecond) == 0) { - QDateTime currentDateTime = QDateTime::currentDateTime(); + // UTC, as m_frameRateTime is: a local QDateTime works its offset out again for + // every difference and conversion below, a time zone lookup under a lock Qt shares + // between all threads - about half of what this cost, in every demodulator + QDateTime currentDateTime = QDateTime::currentDateTimeUtc(); qint64 ms = m_frameRateTime.msecsTo(currentDateTime); if (ms > 0) @@ -1440,11 +1447,12 @@ void AcarsDemodGUI::tick() // Aircraft heard from in the last 5 minutes. ADS-B uses a 10 second window, // but ACARS and VDL-2 aircraft only transmit every so often. const qint64 activeSeconds = 5 * 60; - QMutableHashIterator itr(m_aircraftLastSeen); + const qint64 nowMs = currentDateTime.toMSecsSinceEpoch(); + QMutableHashIterator itr(m_aircraftLastSeen); while (itr.hasNext()) { itr.next(); - if (itr.value().secsTo(currentDateTime) > activeSeconds) { + if ((nowMs - itr.value()) / 1000 > activeSeconds) { itr.remove(); } } @@ -1472,7 +1480,7 @@ void AcarsDemodGUI::tick() } else { - endTime = QDateTime::currentDateTime().addSecs(-ageMins*60); + endTime = QDateTime::currentDateTimeUtc().addSecs(-ageMins*60); startTime = endTime.addSecs(-averagePeriodMins*60); } @@ -1560,15 +1568,23 @@ void AcarsDemodGUI::averageSeries(QLineSeries *series, const QDateTime& startTim int startIdx = 0; int endIdx = -1; + // The points are epoch milliseconds, so compare them as such. Making a QDateTime of + // each meant a local time zone lookup per point, under a lock Qt shares between all + // threads - and this walks back over 10 minutes of points in every series, in every + // ACARS demodulator at once, since they share the master timer: a ~450 ms GUI stall + // every minute + const qint64 startMs = startTime.toMSecsSinceEpoch(); + const qint64 endMs = endTime.toMSecsSinceEpoch(); + for (int i = series->count() - 1; i >= 0; i--) { - QDateTime dt = QDateTime::fromMSecsSinceEpoch(series->at(i).x()); + const qint64 ms = (qint64) series->at(i).x(); - if ((endIdx == -1) && (dt <= endTime)) + if ((endIdx == -1) && (ms <= endMs)) { endIdx = i; } - else if (dt < startTime) + else if (ms < startMs) { startIdx = i + 1; break; diff --git a/plugins/channelrx/demodacars/acarsdemodgui.h b/plugins/channelrx/demodacars/acarsdemodgui.h index 3519186cd..1e8815947 100644 --- a/plugins/channelrx/demodacars/acarsdemodgui.h +++ b/plugins/channelrx/demodacars/acarsdemodgui.h @@ -1,244 +1,244 @@ -/////////////////////////////////////////////////////////////////////////////////// -// Copyright (C) 2016 Edouard Griffiths, F4EXB // -// Copyright (C) 2021 Jon Beniston, M7RCE // -// // -// This program is free software; you can redistribute it and/or modify // -// it under the terms of the GNU General Public License as published by // -// the Free Software Foundation as version 3 of the License, or // -// (at your option) any later version. // -// // -// This program is distributed in the hope that it will be useful, // -// but WITHOUT ANY WARRANTY; without even the implied warranty of // -// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // -// GNU General Public License V3 for more details. // -// // -// You should have received a copy of the GNU General Public License // -// along with this program. If not, see . // -/////////////////////////////////////////////////////////////////////////////////// - -#ifndef INCLUDE_ACARSDEMODGUI_H -#define INCLUDE_ACARSDEMODGUI_H - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#include "channel/channelgui.h" -#include "dsp/channelmarker.h" -#include "util/messagequeue.h" -#include "util/planespotters.h" -#include "settings/rollupstate.h" -#include "util/acarsmessage.h" -#include "gui/acarsmessageview.h" -#include "acarsdemodsettings.h" -#include "acarsdemodworker.h" -#include "acarsmessagemodel.h" -#include "acarsvdl2.h" -#include "acarshfdl.h" -#include "util/osndb.h" -#include "util/ourairportsdb.h" -#include "util/aircraftreport.h" - -class PluginAPI; -class DeviceUISet; -class BasebandSampleSink; -class AcarsDemod; -class AcarsDemodGUI; -class ScopeVis; - -#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) -using namespace QtCharts; // Qt6 moved the chart classes out of this namespace -#endif - -namespace Ui { - class AcarsDemodGUI; -} -class AcarsDemodGUI; - -class AcarsDemodGUI : public ChannelGUI { - Q_OBJECT - -public: - static AcarsDemodGUI* create(PluginAPI* pluginAPI, DeviceUISet *deviceUISet, BasebandSampleSink *rxChannel); - virtual void destroy(); - - void resetToDefaults(); - QByteArray serialize() const; - bool deserialize(const QByteArray& data); - virtual MessageQueue *getInputMessageQueue() { return &m_inputMessageQueue; } - virtual void setWorkspaceIndex(int index) { m_settings.m_workspaceIndex = index; }; - virtual int getWorkspaceIndex() const { return m_settings.m_workspaceIndex; }; - virtual void setGeometryBytes(const QByteArray& blob) { m_settings.m_geometryBytes = blob; }; - virtual QByteArray getGeometryBytes() const { return m_settings.m_geometryBytes; }; - virtual QString getTitle() const { return m_settings.m_title; }; - virtual QColor getTitleColor() const { return m_settings.m_rgbColor; }; - virtual void zetHidden(bool hidden) { m_settings.m_hidden = hidden; } - virtual bool getHidden() const { return m_settings.m_hidden; } - virtual ChannelMarker& getChannelMarker() { return m_channelMarker; } - virtual int getStreamIndex() const { return m_settings.m_streamIndex; } - virtual void setStreamIndex(int streamIndex) { m_settings.m_streamIndex = streamIndex; } - -public slots: - void channelMarkerChangedByCursor(); - void channelMarkerHighlightedByCursor(); - -private: - Ui::AcarsDemodGUI* ui; - PluginAPI* m_pluginAPI; - DeviceUISet* m_deviceUISet; - ChannelMarker m_channelMarker; - RollupState m_rollupState; - AcarsDemodSettings m_settings; - bool m_doApplySettings; - ScopeVis* m_scopeVis; - - AcarsDemod* m_acarsDemod; - qint64 m_deviceCenterFrequency; - int m_basebandSampleRate; - uint32_t m_tickCount; - MessageQueue m_inputMessageQueue; - - PlaneSpotters m_planeSpotters; - QString m_photoLink; - QSharedPointer> m_aircraftInfo; - OsnDB m_osnDB; - QProgressDialog *m_progressDialog; - - QMenu *menu; // Column select context menu - - AcarsMessageModel *m_messageModel; - AcarsMessageFilter *m_messageFilter; - - // Scrolling to the newest message is coalesced on to this timer rather than done per - // message: measured at 41 messages a second it was 393 us each, because - // scrollToBottom forces a synchronous relayout, and one relayout serves every - // message that arrived in the tick - QTimer *m_tableTimer; - bool m_scrollPending; - - // Maps a row of the table as displayed to the model row behind it - int sourceRow(int viewRow) const; - QString udpToolTip() const; - - // Multipart assembly states from the worker, for the decode view - QHash m_assemblies; - - // Frames received per second chart - QChart *m_chart; - // One series per row type, indexed by AcarsRowEvent::m_frameType, so a protocol - // cannot be added without a series appearing for it. There used to be two series - - // "ACARS" and "VDL-2 link" - with everything that was not an ACARS message counted - // into the second one, so in HFDL or Aero mode the legend named the wrong protocol. - static const int CHART_FRAME_SERIES = 4; - static const char *m_frameSeriesNames[CHART_FRAME_SERIES]; - QLineSeries *m_frameRateSeries[CHART_FRAME_SERIES]; - QLineSeries *m_aircraftSeries; - - bool anyFrameSeriesVisible() const; - QDateTimeAxis *m_xAxis; - QValueAxis *m_fpsYAxis; - QValueAxis *m_aircraftYAxis; - int m_frameRateCount[CHART_FRAME_SERIES]; - QDateTime m_frameRateTime; - QHash m_aircraftLastSeen; // For the aircraft-seen series - QDateTime m_averageTime; // Up to when old chart data has been averaged - QPoint m_chartPanPos; - bool m_chartPanning; - - // HFDL ground stations and the frequencies they announced in squitters - struct GsHeard - { - QSet m_frequencies; // kHz - QDateTime m_lastHeard; - }; - QHash m_gsHeard; - - QDialog *m_gsDialog = nullptr; - QTableWidget *m_gsTableWidget = nullptr; - - explicit AcarsDemodGUI(PluginAPI* pluginAPI, DeviceUISet *deviceUISet, BasebandSampleSink *rxChannel, QWidget* parent = 0); - virtual ~AcarsDemodGUI(); - - void blockApplySettings(bool block); - void applySettings(bool force = false); - void displaySettings(); - void updateModeDependentWidgets(); - void applyModeBandwidth(); - void updateChannelMarker(); - void updateGsTable(); - void sendGroundStationToMap(const QString& name, float latitude, float longitude, const QString& text, QDateTime dateTime); - bool handleMessage(const Message& message); - void plotChart(); - void resetChartAxes(); - static void averageSeries(QLineSeries *series, const QDateTime& startTime, const QDateTime& endTime); - void makeUIConnections(); - void updateAbsoluteCenterFrequency(); - void updatePhotoText(const QString& registration); - void hideAircraftDetails(); - - void leaveEvent(QEvent*); - void enterEvent(EnterEventType*); - virtual bool eventFilter(QObject *obj, QEvent *event) override; - - void resizeTable(); - QAction *createCheckableItem(QString& text, int idx, bool checked); - -private slots: - void on_deltaFrequency_changed(qint64 value); - void on_mode_currentIndexChanged(int value); - void on_aeroChannel_currentIndexChanged(int value); - void on_iridiumBandwidth_currentIndexChanged(int value); - void on_gsTable_clicked(); - void gsTableContextMenu(QPoint pos); - void on_rfBW_valueChanged(int index); - void on_threshold_valueChanged(int value); - void on_filter_currentIndexChanged(int index); - void on_filterPattern_editingFinished(); - void on_clearTable_clicked(); - void on_udpEnabled_clicked(bool checked); - void udpSettings(const QPoint& p); - void on_getOSNDB_clicked(); - void applyFilter(); - void restoreSplitter(); - void on_logEnable_clicked(bool checked=false); - void on_logFilename_clicked(); - void on_logOpen_clicked(); - void on_displayChart_clicked(bool checked); - void on_noInfo_clicked(bool checked); - void updateMessagesTable(); - void setShowDate(bool showDate); - void clearChart(const QPoint& p); - void legendMarkerClicked(); - void on_channel1_currentIndexChanged(int index); - void on_channel2_currentIndexChanged(int index); - void messages_sectionMoved(int logicalIndex, int oldVisualIndex, int newVisualIndex); - void messages_sectionResized(int logicalIndex, int oldSize, int newSize); - void messagesSelectionChanged(); - void customContextMenuRequested(QPoint point); - void columnSelectMenu(QPoint pos); - void columnSelectMenuChecked(bool checked = false); - void onWidgetRolled(QWidget* widget, bool rollDown); - void onMenuDialogCalled(const QPoint& p); - void handleInputMessages(); - void tick(); - void downloadingURL(const QString& url); - void downloadError(const QString& error); - void downloadProgress(qint64 bytesRead, qint64 totalBytes); - void downloadAircraftInformationFinished(); - void aircraftPhoto(const PlaneSpottersPhoto *photo); - void photoClicked(); - - // Display events from the channel's worker, which does all the decode - void rowReady(const AcarsRowEvent& event); - void assemblyUpdated(const AcarsAssemblyEvent& event); -}; - -#endif // INCLUDE_ACARSDEMODGUI_H +/////////////////////////////////////////////////////////////////////////////////// +// Copyright (C) 2016 Edouard Griffiths, F4EXB // +// Copyright (C) 2021 Jon Beniston, M7RCE // +// // +// This program is free software; you can redistribute it and/or modify // +// it under the terms of the GNU General Public License as published by // +// the Free Software Foundation as version 3 of the License, or // +// (at your option) any later version. // +// // +// This program is distributed in the hope that it will be useful, // +// but WITHOUT ANY WARRANTY; without even the implied warranty of // +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // +// GNU General Public License V3 for more details. // +// // +// You should have received a copy of the GNU General Public License // +// along with this program. If not, see . // +/////////////////////////////////////////////////////////////////////////////////// + +#ifndef INCLUDE_ACARSDEMODGUI_H +#define INCLUDE_ACARSDEMODGUI_H + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "channel/channelgui.h" +#include "dsp/channelmarker.h" +#include "util/messagequeue.h" +#include "util/planespotters.h" +#include "settings/rollupstate.h" +#include "util/acarsmessage.h" +#include "gui/acarsmessageview.h" +#include "acarsdemodsettings.h" +#include "acarsdemodworker.h" +#include "acarsmessagemodel.h" +#include "acarsvdl2.h" +#include "acarshfdl.h" +#include "util/osndb.h" +#include "util/ourairportsdb.h" +#include "util/aircraftreport.h" + +class PluginAPI; +class DeviceUISet; +class BasebandSampleSink; +class AcarsDemod; +class AcarsDemodGUI; +class ScopeVis; + +#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) +using namespace QtCharts; // Qt6 moved the chart classes out of this namespace +#endif + +namespace Ui { + class AcarsDemodGUI; +} +class AcarsDemodGUI; + +class AcarsDemodGUI : public ChannelGUI { + Q_OBJECT + +public: + static AcarsDemodGUI* create(PluginAPI* pluginAPI, DeviceUISet *deviceUISet, BasebandSampleSink *rxChannel); + virtual void destroy(); + + void resetToDefaults(); + QByteArray serialize() const; + bool deserialize(const QByteArray& data); + virtual MessageQueue *getInputMessageQueue() { return &m_inputMessageQueue; } + virtual void setWorkspaceIndex(int index) { m_settings.m_workspaceIndex = index; }; + virtual int getWorkspaceIndex() const { return m_settings.m_workspaceIndex; }; + virtual void setGeometryBytes(const QByteArray& blob) { m_settings.m_geometryBytes = blob; }; + virtual QByteArray getGeometryBytes() const { return m_settings.m_geometryBytes; }; + virtual QString getTitle() const { return m_settings.m_title; }; + virtual QColor getTitleColor() const { return m_settings.m_rgbColor; }; + virtual void zetHidden(bool hidden) { m_settings.m_hidden = hidden; } + virtual bool getHidden() const { return m_settings.m_hidden; } + virtual ChannelMarker& getChannelMarker() { return m_channelMarker; } + virtual int getStreamIndex() const { return m_settings.m_streamIndex; } + virtual void setStreamIndex(int streamIndex) { m_settings.m_streamIndex = streamIndex; } + +public slots: + void channelMarkerChangedByCursor(); + void channelMarkerHighlightedByCursor(); + +private: + Ui::AcarsDemodGUI* ui; + PluginAPI* m_pluginAPI; + DeviceUISet* m_deviceUISet; + ChannelMarker m_channelMarker; + RollupState m_rollupState; + AcarsDemodSettings m_settings; + bool m_doApplySettings; + ScopeVis* m_scopeVis; + + AcarsDemod* m_acarsDemod; + qint64 m_deviceCenterFrequency; + int m_basebandSampleRate; + uint32_t m_tickCount; + MessageQueue m_inputMessageQueue; + + PlaneSpotters m_planeSpotters; + QString m_photoLink; + QSharedPointer> m_aircraftInfo; + OsnDB m_osnDB; + QProgressDialog *m_progressDialog; + + QMenu *menu; // Column select context menu + + AcarsMessageModel *m_messageModel; + AcarsMessageFilter *m_messageFilter; + + // Scrolling to the newest message is coalesced on to this timer rather than done per + // message: measured at 41 messages a second it was 393 us each, because + // scrollToBottom forces a synchronous relayout, and one relayout serves every + // message that arrived in the tick + QTimer *m_tableTimer; + bool m_scrollPending; + + // Maps a row of the table as displayed to the model row behind it + int sourceRow(int viewRow) const; + QString udpToolTip() const; + + // Multipart assembly states from the worker, for the decode view + QHash m_assemblies; + + // Frames received per second chart + QChart *m_chart; + // One series per row type, indexed by AcarsRowEvent::m_frameType, so a protocol + // cannot be added without a series appearing for it. There used to be two series - + // "ACARS" and "VDL-2 link" - with everything that was not an ACARS message counted + // into the second one, so in HFDL or Aero mode the legend named the wrong protocol. + static const int CHART_FRAME_SERIES = 4; + static const char *m_frameSeriesNames[CHART_FRAME_SERIES]; + QLineSeries *m_frameRateSeries[CHART_FRAME_SERIES]; + QLineSeries *m_aircraftSeries; + + bool anyFrameSeriesVisible() const; + QDateTimeAxis *m_xAxis; + QValueAxis *m_fpsYAxis; + QValueAxis *m_aircraftYAxis; + int m_frameRateCount[CHART_FRAME_SERIES]; + QDateTime m_frameRateTime; + QHash m_aircraftLastSeen; // For the aircraft-seen series: epoch ms + QDateTime m_averageTime; // Up to when old chart data has been averaged + QPoint m_chartPanPos; + bool m_chartPanning; + + // HFDL ground stations and the frequencies they announced in squitters + struct GsHeard + { + QSet m_frequencies; // kHz + QDateTime m_lastHeard; + }; + QHash m_gsHeard; + + QDialog *m_gsDialog = nullptr; + QTableWidget *m_gsTableWidget = nullptr; + + explicit AcarsDemodGUI(PluginAPI* pluginAPI, DeviceUISet *deviceUISet, BasebandSampleSink *rxChannel, QWidget* parent = 0); + virtual ~AcarsDemodGUI(); + + void blockApplySettings(bool block); + void applySettings(bool force = false); + void displaySettings(); + void updateModeDependentWidgets(); + void applyModeBandwidth(); + void updateChannelMarker(); + void updateGsTable(); + void sendGroundStationToMap(const QString& name, float latitude, float longitude, const QString& text, QDateTime dateTime); + bool handleMessage(const Message& message); + void plotChart(); + void resetChartAxes(); + static void averageSeries(QLineSeries *series, const QDateTime& startTime, const QDateTime& endTime); + void makeUIConnections(); + void updateAbsoluteCenterFrequency(); + void updatePhotoText(const QString& registration); + void hideAircraftDetails(); + + void leaveEvent(QEvent*); + void enterEvent(EnterEventType*); + virtual bool eventFilter(QObject *obj, QEvent *event) override; + + void resizeTable(); + QAction *createCheckableItem(QString& text, int idx, bool checked); + +private slots: + void on_deltaFrequency_changed(qint64 value); + void on_mode_currentIndexChanged(int value); + void on_aeroChannel_currentIndexChanged(int value); + void on_iridiumBandwidth_currentIndexChanged(int value); + void on_gsTable_clicked(); + void gsTableContextMenu(QPoint pos); + void on_rfBW_valueChanged(int index); + void on_threshold_valueChanged(int value); + void on_filter_currentIndexChanged(int index); + void on_filterPattern_editingFinished(); + void on_clearTable_clicked(); + void on_udpEnabled_clicked(bool checked); + void udpSettings(const QPoint& p); + void on_getOSNDB_clicked(); + void applyFilter(); + void restoreSplitter(); + void on_logEnable_clicked(bool checked=false); + void on_logFilename_clicked(); + void on_logOpen_clicked(); + void on_displayChart_clicked(bool checked); + void on_noInfo_clicked(bool checked); + void updateMessagesTable(); + void setShowDate(bool showDate); + void clearChart(const QPoint& p); + void legendMarkerClicked(); + void on_channel1_currentIndexChanged(int index); + void on_channel2_currentIndexChanged(int index); + void messages_sectionMoved(int logicalIndex, int oldVisualIndex, int newVisualIndex); + void messages_sectionResized(int logicalIndex, int oldSize, int newSize); + void messagesSelectionChanged(); + void customContextMenuRequested(QPoint point); + void columnSelectMenu(QPoint pos); + void columnSelectMenuChecked(bool checked = false); + void onWidgetRolled(QWidget* widget, bool rollDown); + void onMenuDialogCalled(const QPoint& p); + void handleInputMessages(); + void tick(); + void downloadingURL(const QString& url); + void downloadError(const QString& error); + void downloadProgress(qint64 bytesRead, qint64 totalBytes); + void downloadAircraftInformationFinished(); + void aircraftPhoto(const PlaneSpottersPhoto *photo); + void photoClicked(); + + // Display events from the channel's worker, which does all the decode + void rowReady(const AcarsRowEvent& event); + void assemblyUpdated(const AcarsAssemblyEvent& event); +}; + +#endif // INCLUDE_ACARSDEMODGUI_H