Browse Source

filesink: Prevent unsafe copying of FileSinkSink

Explicitly delete the copy constructor and copy assignment operator for
FileSinkSink, which manages resources that should not be shared through
implicit shallow copies.

The implicitly generated copy operations could leave multiple FileSinkSink
instances referring to the same resources, potentially causing invalid
ownership or double deletion.

Since FileSinkSink is not intended to be copied or assigned, prohibit both
operations at compile time, turning potential runtime errors into
compile-time errors.

cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 1 month ago
parent
commit
84fbb4d761
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 4
      plugins/channelrx/filesink/filesinksink.h

4
plugins/channelrx/filesink/filesinksink.h

@ -35,7 +35,9 @@ class SpectrumVis; @@ -35,7 +35,9 @@ class SpectrumVis;
class FileSinkSink : public ChannelSampleSink {
public:
FileSinkSink();
~FileSinkSink();
~FileSinkSink();
FileSinkSink(const FileSinkSink&) = delete;
FileSinkSink& operator=(const FileSinkSink&) = delete;
virtual void feed(const SampleVector::const_iterator& begin, const SampleVector::const_iterator& end);

Loading…
Cancel
Save