Browse Source

ft8: Prevent unsafe copy construction and assignment of FFTEngine

Explicitly delete the copy constructor and copy assignment operator for
FFTEngine, which owns dynamically allocated FFTBuffers.

Allowing the implicitly generated copy operations would result in shallow
copies of m_fftBuffers, leaving multiple FFTEngine instances referring to
the same resource and potentially causing invalid ownership or double
deletion.

Since FFTEngine is not intended to be copied or assigned, prohibit both
operations at compile time, turning potential runtime errors into
compile-time errors.

cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 1 month ago
parent
commit
8f87a67ed6
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 2
      ft8/fft.h

2
ft8/fft.h

@ -49,6 +49,8 @@ public: @@ -49,6 +49,8 @@ public:
FFTEngine();
~FFTEngine();
FFTEngine(const FFTEngine&) = delete;
FFTEngine& operator=(const FFTEngine&) = delete;
private:
std::vector<std::complex<float>> analytic(const std::vector<float> &x);

Loading…
Cancel
Save