Browse Source

dsp/fftnr : Initialize FFT noise reduction state

Initialize FFTNoiseReduction magnitude state and ExponentialFilter previous
value so noise reduction calculations start from defined values. This
prevents undefined behavior from using uninitialized state during filtering.

Found by cppcheck (uninitMemberVar).

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 2 months ago
parent
commit
95875e2f5c
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 7
      sdrbase/dsp/fftnr.cpp

7
sdrbase/dsp/fftnr.cpp

@ -25,7 +25,9 @@ @@ -25,7 +25,9 @@
#include "fftnr.h"
FFTNoiseReduction::FFTNoiseReduction(int len) :
m_flen(len)
m_flen(len),
m_magAvg(0.0f),
m_magThr(0.0f)
{
m_scheme = SchemeAverage;
m_mags = new float[m_flen];
@ -107,7 +109,8 @@ void FFTNoiseReduction::setScheme(Scheme scheme) @@ -107,7 +109,8 @@ void FFTNoiseReduction::setScheme(Scheme scheme)
m_scheme = scheme;
}
FFTNoiseReduction::ExponentialFilter::ExponentialFilter()
FFTNoiseReduction::ExponentialFilter::ExponentialFilter() :
m_prev(0.0f)
{
m_alpha = 1.0;
m_init = true;

Loading…
Cancel
Save