Browse Source
writeData() runs on the audio input thread and iterates m_audioFifos without a lock, while addFifo()/removeFifo() are called from other threads. A modulator with audio input (e.g. SSB Mod) removes and re-adds its FIFO each time it starts, so starting a Tx device while audio is flowing could crash in AudioFifo::write() (SIGSEGV in QBasicMutex::lockInternal) when the list changed under the iteration. Keying the transmitter often (e.g. FT8 via WSJT-X) hit it within hours. Protect the list with its own mutex, held only for the list operations. m_mutex is left alone, so this does not bring back the lockups the commented out lock in writeData() was removed for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>chirpmodem-v8.0.0
2 changed files with 8 additions and 3 deletions
Loading…
Reference in new issue