Browse Source

modemdrm: Guard against missing spectrum parameters

Fix Coverity CID 657650 by checking the result of
Parameters::forSpectrum() before dereferencing it in
estimateFrameWiener(). Return false if no spectrum parameters
are available.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.1.0
Robin Getz 4 weeks ago
parent
commit
b34caee95c
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 3
      modemdrm/drmchannelestimator.cpp

3
modemdrm/drmchannelestimator.cpp

@ -1578,6 +1578,9 @@ bool ChannelEstimationContext::estimateFrameWiener( @@ -1578,6 +1578,9 @@ bool ChannelEstimationContext::estimateFrameWiener(
const auto& fftFrames = *m_frames;
const ModeParameters& parameters = Parameters::forMode(mode);
const SpectrumParameters* spectrum = Parameters::forSpectrum(mode, occupancy);
if (!spectrum) {
return false;
}
const int carrierCount = spectrum->maximumCarrier - spectrum->minimumCarrier + 1;
const float temporalCorrelation = m_temporalCorrelation;
const TemporalWeights weights = temporalWeights(temporalCorrelation);

Loading…
Cancel
Save