From cae296d8e3d416ca003bbb1931b7053e290213f3 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Tue, 27 Oct 2026 23:55:12 -0400 Subject: [PATCH] sdrbase/util: Handle unknown replies in downloadFinished() Fix Coverity CID 652510 by handling replies missing from m_downloads. This error case could cause an invalid index into m_filenames. Log a warning, schedule the reply for deletion, and return. Signed-off-by: Robin Getz --- sdrbase/util/httpdownloadmanager.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sdrbase/util/httpdownloadmanager.cpp b/sdrbase/util/httpdownloadmanager.cpp index f98da9cd3..bb0a980a2 100644 --- a/sdrbase/util/httpdownloadmanager.cpp +++ b/sdrbase/util/httpdownloadmanager.cpp @@ -123,6 +123,11 @@ void HttpDownloadManager::downloadFinished(QNetworkReply *reply) { QString url = reply->url().toEncoded().constData(); int idx = m_downloads.indexOf(reply); + if (idx < 0) { + qWarning("HttpDownloadManager::downloadFinished: reply not found in downloads"); + reply->deleteLater(); + return; + } QString filename = m_filenames[idx]; bool success = false; bool retry = false;