From cdfe0a7130a87aaeae6793f573299eaf897a2428 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Tue, 27 Oct 2026 23:49:51 -0400 Subject: [PATCH] sdrbase/channel: Guard against null Web API error messages Fix Coverity CIDs 652172, 652242, 652256, 652288, 652572, 652666, and 652679 by checking error message pointers before dereferencing them. Use "Unknown error" when no message is available. Also use Printable for the successful channel setting debug log. Signed-off-by: Robin Getz --- sdrbase/channel/channelwebapiutils.cpp | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/sdrbase/channel/channelwebapiutils.cpp b/sdrbase/channel/channelwebapiutils.cpp index 6731f00b7..dd2fdaf7b 100644 --- a/sdrbase/channel/channelwebapiutils.cpp +++ b/sdrbase/channel/channelwebapiutils.cpp @@ -397,8 +397,9 @@ bool ChannelWebAPIUtils::setCenterFrequency(unsigned int deviceIndex, double fre } else { + QString *message = errorResponse2.getMessage(); qWarning("ChannelWebAPIUtils::setCenterFrequency: set device frequency error %d: %s", - httpRC, qPrintable(*errorResponse2.getMessage())); + httpRC, message ? qPrintable(*message) : "Unknown error"); return false; } } @@ -1444,8 +1445,9 @@ bool ChannelWebAPIUtils::patchDeviceSetting(unsigned int deviceIndex, const QStr } else { + QString *message = errorResponse2.getMessage(); qWarning("ChannelWebAPIUtils::patchDeviceSetting: set device setting error %d: %s", - httpRC, qPrintable(*errorResponse2.getMessage())); + httpRC, message ? qPrintable(*message) : "Unknown error"); return false; } } @@ -1501,8 +1503,9 @@ bool ChannelWebAPIUtils::patchDeviceSetting(unsigned int deviceIndex, const QStr } else { + QString *message = errorResponse2.getMessage(); qWarning("ChannelWebAPIUtils::patchDeviceSetting: set device setting error %d: %s", - httpRC, qPrintable(*errorResponse2.getMessage())); + httpRC, message ? qPrintable(*message) : "Unknown error"); return false; } } @@ -1550,8 +1553,9 @@ bool ChannelWebAPIUtils::patchFeatureSetting(unsigned int featureSetIndex, unsig } else { + QString *message = errorResponse2.getMessage(); qWarning("ChannelWebAPIUtils::patchFeatureSetting: set feature setting %s to %s error %d: %s", - qPrintable(setting), qPrintable(value), httpRC, qPrintable(*errorResponse2.getMessage())); + qPrintable(setting), qPrintable(value), httpRC, message ? qPrintable(*message) : "Unknown error"); return false; } } @@ -1599,8 +1603,9 @@ bool ChannelWebAPIUtils::patchFeatureSetting(unsigned int featureSetIndex, unsig } else { + QString *message = errorResponse2.getMessage(); qWarning("ChannelWebAPIUtils::patchFeatureSetting: set feature setting %s to %f error %d: %s", - qPrintable(setting), value, httpRC, qPrintable(*errorResponse2.getMessage())); + qPrintable(setting), value, httpRC, message ? qPrintable(*message) : "Unknown error"); return false; } } @@ -1680,8 +1685,9 @@ bool ChannelWebAPIUtils::patchFeatureSetting(unsigned int featureSetIndex, unsig } else { + QString *message = errorResponse2.getMessage(); qWarning("ChannelWebAPIUtils::patchFeatureSetting: set feature setting %s error %d: %s", - qPrintable(setting), httpRC, qPrintable(*errorResponse2.getMessage())); + qPrintable(setting), httpRC, message ? qPrintable(*message) : "Unknown error"); return false; } } @@ -1720,8 +1726,9 @@ bool ChannelWebAPIUtils::patchChannelSetting(ChannelAPI *channel, const QString } else { + QString *message = errorResponse2.getMessage(); qWarning("ChannelWebAPIUtils::patchChannelSetting: set feature setting %s to %s error %d: %s", - qPrintable(setting), qPrintable(value.toString()), httpRC, qPrintable(*errorResponse2.getMessage())); + qPrintable(setting), qPrintable(value.toString()), httpRC, message ? qPrintable(*message) : "Unknown error"); return false; } } @@ -1834,8 +1841,9 @@ bool ChannelWebAPIUtils::patchChannelSetting(unsigned int deviceSetIndex, unsign } else { + QString *message = errorResponse2.getMessage(); qWarning("ChannelWebAPIUtils::patchChannelSetting: set channel setting error %d: %s", - httpRC, qPrintable(*errorResponse2.getMessage())); + httpRC, message ? qPrintable(*message) : "Unknown error"); return false; } }