Browse Source

audiofilter : Initialize AudioFilter state buffers

Initialize the filter state buffers in the constructor so filter processing
starts from a defined state rather than reading uninitialized values. This
avoids undefined behavior and makes the initial filter output deterministic.

Found by cppcheck (uninitMemberVar).

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 2 months ago
parent
commit
de30b367ac
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 10
      sdrbase/audio/audiofilter.cpp

10
sdrbase/audio/audiofilter.cpp

@ -33,9 +33,13 @@ const float AudioFilter::m_hpa[3] = {1.000000e+00, 1.667871e+00, -7.156964e-01} @@ -33,9 +33,13 @@ const float AudioFilter::m_hpa[3] = {1.000000e+00, 1.667871e+00, -7.156964e-01}
const float AudioFilter::m_hpb[3] = {8.459039e-01, -1.691760e+00, 8.459039e-01};
AudioFilter::AudioFilter() :
m_filterLP(m_lpa, m_lpb),
m_filterHP(m_hpa, m_hpb),
m_useHP(false)
m_filterLP(m_lpa, m_lpb),
m_filterHP(m_hpa, m_hpb),
m_useHP(false),
m_lpva{},
m_lpvb{},
m_hpva{},
m_hpvb{}
{}
AudioFilter::~AudioFilter()

Loading…
Cancel
Save