Browse Source

Merge pull request #2984 from rgetz/rgetz-fix-uninitMemberVar-remaining

Fix remaining uninitialized member variables and unset variable warnings
chirpmodem-v8.0.0
Edouard Griffiths 2 months ago committed by GitHub
parent
commit
e4255e3fd2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 5
      ft8/ft8.cpp
  2. 3
      httpserver/httpcookie.cpp
  3. 2
      modemm17/FirFilter.h
  4. 3
      modemm17/M17FrameDecoder.h
  5. 2
      modemm17/PolynomialInterleaver.h
  6. 1
      modemm17/ax25_frame.h
  7. 2
      plugins/channelrx/demoddatv/leansdr/dvb.h
  8. 3
      plugins/channelrx/demodmeshcore/meshcoredemod.cpp
  9. 32
      plugins/channelrx/demodpager/pagerdemodflex.cpp
  10. 4
      plugins/channelrx/demodpsk31/psk31demodulator.cpp
  11. 4
      plugins/channelrx/radioastronomy/radioastronomygui.cpp
  12. 1
      plugins/channelrx/remotetcpsink/remotetcpsink.cpp
  13. 6
      plugins/channeltx/moddatv/datvmodsettings.cpp
  14. 3
      plugins/channeltx/moddatv/datvmodsource.cpp
  15. 3
      plugins/channeltx/moddatv/tsgenerator.cpp
  16. 1
      plugins/feature/aprs/aprs.cpp
  17. 4
      plugins/feature/mcpserver/mcpaudiocapture.cpp
  18. 5
      plugins/feature/mcpserver/mcptools.cpp
  19. 4
      plugins/feature/radiosonde/radiosondegui.cpp
  20. 1
      plugins/samplemimo/metismiso/metismisoudphandler.cpp
  21. 3
      qrtplib/rtcpapppacket.cpp
  22. 22
      qrtplib/rtcppacketbuilder.cpp
  23. 3
      qrtplib/rtpkeyhashtable.h
  24. 14
      qrtplib/rtpsession.cpp
  25. 13
      sdrbase/util/radiosonde.cpp
  26. 2
      sdrbase/util/serialutil.cpp
  27. 1
      sdrgui/device/devicegui.cpp
  28. 4
      sdrgui/device/deviceuiset.cpp
  29. 1
      sdrgui/feature/featuregui.cpp
  30. 1
      sdrgui/gui/basicchannelsettingsdialog.cpp
  31. 4
      sdrgui/gui/basicfeaturesettingsdialog.cpp
  32. 3
      sdrgui/gui/configurationsdialog.cpp
  33. 3
      sdrgui/gui/coursedeviationindicator.cpp
  34. 1
      sdrgui/gui/devicesetselectiondialog.cpp
  35. 7
      sdrgui/gui/featurelayout.cpp
  36. 9
      sdrgui/gui/fftnrdialog.cpp
  37. 2
      sdrgui/gui/fmpreemphasisdialog.cpp
  38. 1
      sdrgui/gui/glscope.h
  39. 4
      sdrgui/gui/glspectrumview.cpp
  40. 5
      sdrgui/gui/logslider.cpp
  41. 2
      sdrgui/gui/scaleengine.cpp
  42. 3
      sdrgui/gui/sdrangelsplash.cpp
  43. 3
      sdrgui/gui/spectrummeasurements.cpp
  44. 16
      sdrgui/gui/tvscreenanalog.cpp
  45. 1
      sdrgui/gui/workspaceselectiondialog.cpp
  46. 3
      sdrgui/mainwindow.cpp
  47. 7
      wdsp/TXA.cpp
  48. 8
      wdsp/amd.cpp
  49. 1
      wdsp/amsq.cpp
  50. 1
      wdsp/cfcomp.cpp
  51. 6
      wdsp/emnr.cpp
  52. 2
      wdsp/fcurve.cpp
  53. 1
      wdsp/fmsq.cpp
  54. 7
      wdsp/nbp.cpp
  55. 17
      wdsp/nob.cpp
  56. 3
      wdsp/osctrl.cpp
  57. 1
      wdsp/siphon.cpp
  58. 3
      wdsp/snotch.cpp
  59. 1
      wdsp/speak.cpp
  60. 3
      wdsp/unit.cpp
  61. 5
      wdsp/wcpAGC.cpp

5
ft8/ft8.cpp

@ -84,7 +84,10 @@ FT8::FT8( @@ -84,7 +84,10 @@ FT8::FT8(
CallbackInterface *cb,
const std::vector<cdecode> &prevdecs,
FFTEngine *fftEngine
)
):
pass_(0),
hack_0_(0.0f),
hack_1_(0.0f)
{
samples_ = samples;
min_hz_ = min_hz;

3
httpserver/httpcookie.cpp

@ -28,7 +28,8 @@ HttpCookie::HttpCookie(const QByteArray name, const QByteArray value, const int @@ -28,7 +28,8 @@ HttpCookie::HttpCookie(const QByteArray name, const QByteArray value, const int
this->version=1;
}
HttpCookie::HttpCookie(const QByteArray source)
HttpCookie::HttpCookie(const QByteArray source) :
httpOnly(false)
{
version=1;
maxAge=0;

2
modemm17/FirFilter.h

@ -51,7 +51,7 @@ private: @@ -51,7 +51,7 @@ private:
template <size_t N>
BaseFirFilter<N> makeFirFilter(const std::array<float, N>& taps)
{
return std::move(BaseFirFilter<N>(taps));
return BaseFirFilter<N>(taps);
}

3
modemm17/M17FrameDecoder.h

@ -107,7 +107,8 @@ struct M17FrameDecoder @@ -107,7 +107,8 @@ struct M17FrameDecoder
M17FrameDecoder(callback_t callback) :
crc_(0x5935, 0xFFFF),
callback_(callback)
callback_(callback),
output_buffer{}
{}
void update_state(std::array<uint8_t, 240>& lsf_output)

2
modemm17/PolynomialInterleaver.h

@ -16,7 +16,7 @@ struct PolynomialInterleaver @@ -16,7 +16,7 @@ struct PolynomialInterleaver
using buffer_t = std::array<int8_t, K>;
using bytes_t = std::array<uint8_t, K / 8>;
alignas(16) buffer_t buffer_;
alignas(16) buffer_t buffer_{};
size_t index(size_t i)
{

1
modemm17/ax25_frame.h

@ -210,6 +210,7 @@ public: @@ -210,6 +210,7 @@ public:
source_(),
repeaters_(),
type_(UNDEFINED),
raw_type_(0),
info_(),
fcs_(-1),
crc_(0),

2
plugins/channelrx/demoddatv/leansdr/dvb.h

@ -1665,7 +1665,7 @@ struct viterbi_sync : runnable @@ -1665,7 +1665,7 @@ struct viterbi_sync : runnable
// that certain rot/conj combinations are equivalent to
// polarity inversion. We could reduce nsyncs.
syncs = new sync[nsyncs];
syncs = new sync[nsyncs]{};
for (int s = 0; s < nsyncs; ++s)
{

3
plugins/channelrx/demodmeshcore/meshcoredemod.cpp

@ -83,7 +83,8 @@ MeshcoreDemod::MeshcoreDemod(DeviceAPI* deviceAPI) : @@ -83,7 +83,8 @@ MeshcoreDemod::MeshcoreDemod(DeviceAPI* deviceAPI) :
m_lastMsgHeaderParityStatus(0),
m_lastMsgPayloadCRC(false),
m_lastMsgPayloadParityStatus(0),
m_udpSink(this, 256)
m_udpSink(this, 256),
m_networkManager(nullptr)
{
setObjectName(m_channelId);
applySettings(m_settings, true);

32
plugins/channelrx/demodpager/pagerdemodflex.cpp

@ -604,7 +604,37 @@ void PagerDemodFlexDecoder::addFragment(PagerDemodFlexMessage& message, int frag @@ -604,7 +604,37 @@ void PagerDemodFlexDecoder::addFragment(PagerDemodFlexMessage& message, int frag
PagerDemodFlex::PagerDemodFlex(int sampleRate) :
m_sampleRate(sampleRate),
m_sps1600(sampleRate / 1600)
m_sps1600(sampleRate / 1600),
m_candidateFlywheel(false),
m_candidateFirst(0),
m_candidateEnd(0),
m_flywheelSyncEnd(0.0),
m_flywheelPeriods(0),
m_flywheelCode(0),
m_flywheelInverted(false),
m_flywheelCycle(0),
m_flywheelFrame(0),
m_syncEnd(0.0),
m_polarity(0.0f),
m_dc(0.0f),
m_deviation(0.0f),
m_syncPower(0.0f),
m_bitIndex(0),
m_nextBitSample(0.0),
m_deviationSum(0.0),
m_fiw(0),
m_sps(0),
m_timing(0.0),
m_gotMid(false),
m_mid(0.0f),
m_prevSymbol(0.0f),
m_havePrevSymbol(false),
m_prevMf(0.0f),
m_symbolIndex(0),
m_sync2Symbols(0),
m_dataSymbols(0),
m_blockPower{},
m_blockSamples{}
{
int histSize = 1;
while (histSize <= m_syncBits * m_sps1600) {

4
plugins/channelrx/demodpsk31/psk31demodulator.cpp

@ -31,8 +31,6 @@ PSK31Demodulator::PSK31Demodulator() : @@ -31,8 +31,6 @@ PSK31Demodulator::PSK31Demodulator() :
m_maxFrequency(0.0f),
m_trackingCutoff(0.0f),
m_trackingNoiseBandwidth(1.0f),
m_afcFrequency(0.0f),
m_afcPhase(0.0f),
m_magsq(0.0),
m_magsqSum(0.0),
m_magsqPeak(0.0),
@ -41,6 +39,8 @@ PSK31Demodulator::PSK31Demodulator() : @@ -41,6 +39,8 @@ PSK31Demodulator::PSK31Demodulator() :
m_afcCount(0),
m_afcCandidate(0.0f),
m_afcCandidateValid(false),
m_afcFrequency(0.0f),
m_afcPhase(0.0f),
m_matchedFilterIndex(0),
m_historyIndex(0),
m_symbolPower(0.0f),

4
plugins/channelrx/radioastronomy/radioastronomygui.cpp

@ -2385,7 +2385,7 @@ void RadioAstronomyGUI::customContextMenuRequested(QPoint pos) @@ -2385,7 +2385,7 @@ void RadioAstronomyGUI::customContextMenuRequested(QPoint pos)
}
std::sort(rows.begin(), rows.end(), std::greater<int>());
bool deletedCurrent = false;
int next;
int next = 0;
foreach (auto row, rows) {
next = row - 1;
if (deleteRow(row)) {
@ -4313,7 +4313,7 @@ void RadioAstronomyGUI::plotFFTMeasurement(int index) @@ -4313,7 +4313,7 @@ void RadioAstronomyGUI::plotFFTMeasurement(int index)
// Plot power/temp
for (int i = 0; i < fft->m_fftSize; i++)
{
qreal value;
qreal value = -std::numeric_limits<qreal>::infinity();
switch (m_settings.m_spectrumYScale)
{
case RadioAstronomySettings::SY_DBFS:

1
plugins/channelrx/remotetcpsink/remotetcpsink.cpp

@ -55,6 +55,7 @@ RemoteTCPSink::RemoteTCPSink(DeviceAPI *deviceAPI) : @@ -55,6 +55,7 @@ RemoteTCPSink::RemoteTCPSink(DeviceAPI *deviceAPI) :
m_deviceAPI(deviceAPI),
m_basebandSampleRate(0),
m_centerFrequency(0),
m_networkManager(nullptr),
m_clients(0),
m_removeRequest(nullptr)
{

6
plugins/channeltx/moddatv/datvmodsettings.cpp

@ -251,6 +251,9 @@ int DATVModSettings::getDVBSDataBitrate() const @@ -251,6 +251,9 @@ int DATVModSettings::getDVBSDataBitrate() const
case DATVModSettings::APSK32:
bitsPerSymbol = 5.0f;
break;
default:
qWarning("DATVModSettings::getDVBSDataBitrate: Unsupported modulation");
return 0;
}
if (m_standard == DATVModSettings::DVB_S)
@ -297,6 +300,9 @@ int DATVModSettings::getDVBSDataBitrate() const @@ -297,6 +300,9 @@ int DATVModSettings::getDVBSDataBitrate() const
case DATVModSettings::FEC35:
convFactor = 3.0f/5.0f;
break;
default:
qWarning("DATVModSettings::getDVBSDataBitrate: Unsupported DVB-S code rate");
return 0;
}
fecFactor = rsFactor * convFactor;
plFactor = 1.0f;

3
plugins/channeltx/moddatv/datvmodsource.cpp

@ -214,7 +214,10 @@ void DATVModSource::checkBitrates() @@ -214,7 +214,10 @@ void DATVModSource::checkBitrates()
qDebug() << "MPEG-TS bitrate: " << m_mpegTSBitrate;
qDebug() << "DVB data bitrate: " << dataBitrate;
if (dataBitrate <= 0)
{
qWarning() << "Unable to calculate DVB data bitrate";
return;
}
if (dataBitrate < m_mpegTSBitrate)
qWarning() << "DVB data bitrate is lower than the bitrate of the MPEG transport stream";
m_tsRatio = m_mpegTSBitrate/(float)dataBitrate;

3
plugins/channeltx/moddatv/tsgenerator.cpp

@ -486,7 +486,8 @@ double TSGenerator::get_dvbs2_rate(double symbol_rate, DATVModSettings::DATVModu @@ -486,7 +486,8 @@ double TSGenerator::get_dvbs2_rate(double symbol_rate, DATVModSettings::DATVModu
fec_den = 5.0;
break;
default:
return symbol_rate * (fec_num / fec_den); // others
qWarning("TSGenerator::get_dvbs2_rate: Unsupported DVB-S2 code rate");
return 0;
}
switch (modulation) {

1
plugins/feature/aprs/aprs.cpp

@ -44,6 +44,7 @@ const char* const APRS::m_featureId = "APRS"; @@ -44,6 +44,7 @@ const char* const APRS::m_featureId = "APRS";
APRS::APRS(WebAPIAdapterInterface *webAPIAdapterInterface) :
Feature(m_featureIdURI, webAPIAdapterInterface),
m_thread(nullptr),
m_packetCount(0),
m_worker(nullptr),
m_availableChannelHandler(APRSSettings::m_pipeURIs, QStringList{"packets"}, "RTMF", this)
{

4
plugins/feature/mcpserver/mcpaudiocapture.cpp

@ -59,9 +59,9 @@ MCPAudioCapture::MCPAudioCapture(WebAPIAdapterInterface *adapter, QObject *paren @@ -59,9 +59,9 @@ MCPAudioCapture::MCPAudioCapture(WebAPIAdapterInterface *adapter, QObject *paren
m_pendingChannel(nullptr),
m_pendingFifo(nullptr),
m_pendingReportQueue(nullptr),
m_stopping(0),
m_capturingChannel(nullptr),
m_captureAborted(0),
m_stopping(0)
m_captureAborted(0)
{
}

5
plugins/feature/mcpserver/mcptools.cpp

@ -1244,7 +1244,7 @@ QString MCPTools::describeType(const QString& typeIn, const QString& kindIn) @@ -1244,7 +1244,7 @@ QString MCPTools::describeType(const QString& typeIn, const QString& kindIn)
out.append("# main spectrum display of a device set\n# get_spectrum_settings / set_spectrum_settings, get_spectrum_report, spectrum_action\n"
"# get_docs spectrum explains the display and its controls\n");
for (const QString& definition : {"GLSpectrum", "GLSpectrumReport", "SpectrumActions"})
for (const QString definition : {"GLSpectrum", "GLSpectrumReport", "SpectrumActions"})
{
if (m_yamlDefinitions.contains(definition))
{
@ -5695,7 +5695,8 @@ void MCPTools::registerIntentTools() @@ -5695,7 +5695,8 @@ void MCPTools::registerIntentTools()
// shows up, 100 kHz off and weaker, and then nothing decodes. So a coarser step on
// a broadcast range is scanned at 100 kHz, which loses nothing where the odd tenths
// are the rule
const bool broadcast = (mode->m_channelType == "BFMDemod") || (mode->m_channelType == "WFMDemod");
const bool broadcast = (QLatin1String(mode->m_channelType) == "BFMDemod") ||
(QLatin1String(mode->m_channelType) == "WFMDemod");
QString rasterNote;
if (fromRange)

4
plugins/feature/radiosonde/radiosondegui.cpp

@ -960,8 +960,8 @@ void RadiosondeGUI::plotChart() @@ -960,8 +960,8 @@ void RadiosondeGUI::plotChart()
{
// Plot selected data
QDateTimeAxis *m_chartXAxis;
QValueAxis *m_chartY1Axis;
QValueAxis *m_chartY2Axis;
QValueAxis *m_chartY1Axis = nullptr;
QValueAxis *m_chartY2Axis = nullptr;
m_chartXAxis = new QDateTimeAxis();
if (m_settings.m_y1 != RadiosondeSettings::NONE) {

1
plugins/samplemimo/metismiso/metismisoudphandler.cpp

@ -42,6 +42,7 @@ MetisMISOUDPHandler::MetisMISOUDPHandler(SampleMIFifo *sampleMIFifo, SampleMOFif @@ -42,6 +42,7 @@ MetisMISOUDPHandler::MetisMISOUDPHandler(SampleMIFifo *sampleMIFifo, SampleMOFif
m_commandBase(0),
m_rxFrame(0),
m_txFrame(0),
metisBufferIndex(0),
m_receiveSequence(0),
m_receiveSequenceError(0),
m_ptt(false),

3
qrtplib/rtcpapppacket.cpp

@ -36,7 +36,8 @@ namespace qrtplib @@ -36,7 +36,8 @@ namespace qrtplib
{
RTCPAPPPacket::RTCPAPPPacket(uint8_t *data, std::size_t datalength) :
RTCPPacket(APP, data, datalength)
RTCPPacket(APP, data, datalength),
appdatalen(0)
{
knownformat = false;

22
qrtplib/rtcppacketbuilder.cpp

@ -41,7 +41,27 @@ namespace qrtplib @@ -41,7 +41,27 @@ namespace qrtplib
{
RTCPPacketBuilder::RTCPPacketBuilder(RTPSources &s, RTPPacketBuilder &pb) :
sources(s), rtppacketbuilder(pb), prevbuildtime(0, 0), transmissiondelay(0, 0)
sources(s),
rtppacketbuilder(pb),
maxpacketsize(0),
timestampunit(0.0),
firstpacket(false),
prevbuildtime(0, 0),
transmissiondelay(0, 0),
interval_name(0),
interval_email(0),
interval_location(0),
interval_phone(0),
interval_tool(0),
interval_note(0),
doname(false),
doemail(false),
doloc(false),
dophone(false),
dotool(false),
donote(false),
processingsdes(false),
sdesbuildcount(0)
{
init = false;
timeinit.Dummy();

3
qrtplib/rtpkeyhashtable.h

@ -124,7 +124,8 @@ private: @@ -124,7 +124,8 @@ private:
};
template<class Key, class Element, class GetIndex, int hashsize>
inline RTPKeyHashTable<Key, Element, GetIndex, hashsize>::RTPKeyHashTable()
inline RTPKeyHashTable<Key, Element, GetIndex, hashsize>::RTPKeyHashTable() :
curhashelem(0)
{
for (int i = 0; i < hashsize; i++)
table[i] = 0;

14
qrtplib/rtpsession.cpp

@ -56,6 +56,20 @@ namespace qrtplib @@ -56,6 +56,20 @@ namespace qrtplib
RTPSession::RTPSession(RTPRandom *r) :
rtprnd(GetRandomNumberGenerator(r)),
rtptrans(nullptr),
deletetransmitter(false),
usingpollthread(false),
acceptownpackets(false),
useSR_BYEifpossible(false),
maxpacksize(0),
sessionbandwidth(0.0),
controlfragment(0.0),
sendermultiplier(0.0),
byemultiplier(0.0),
membermultiplier(0.0),
collisionmultiplier(0.0),
notemultiplier(0.0),
sentpackets(false),
sources(*this),
packetbuilder(*rtprnd),
rtcpsched(sources, *rtprnd),

13
sdrbase/util/radiosonde.cpp

@ -33,6 +33,19 @@ RS41Frame::RS41Frame(const QByteArray ba) : @@ -33,6 +33,19 @@ RS41Frame::RS41Frame(const QByteArray ba) :
m_maxSubframeNumber(0),
m_subframeNumber(0),
m_measValid(false),
m_tempMain(0),
m_tempRef1(0),
m_tempRef2(0),
m_humidityMain(0),
m_humidityRef1(0),
m_humidityRef2(0),
m_humidityTempMain(0),
m_humidityTempRef1(0),
m_humidityTempRef2(0),
m_pressureMain(0),
m_pressureRef1(0),
m_pressureRef2(0),
m_pressureTemp(0.0),
m_gpsInfoValid(false),
m_posValid(false),
m_latitude(0.0),

2
sdrbase/util/serialutil.cpp

@ -58,7 +58,7 @@ void SerialUtil::getComPorts(std::vector<std::string>& comPorts, const std::stri @@ -58,7 +58,7 @@ void SerialUtil::getComPorts(std::vector<std::string>& comPorts, const std::stri
void SerialUtil::getComPorts(std::vector<std::string>& comPorts, const std::string& regexStr)
{
int n;
struct dirent **namelist;
struct dirent **namelist = nullptr;
comPorts.clear();
const char* sysdir = "/sys/class/tty/";
struct stat fileStat;

1
sdrgui/device/devicegui.cpp

@ -41,6 +41,7 @@ DeviceGUI::DeviceGUI(QWidget *parent) : @@ -41,6 +41,7 @@ DeviceGUI::DeviceGUI(QWidget *parent) :
m_deviceUISet(nullptr),
m_deviceType(DeviceRx),
m_deviceSetIndex(0),
m_workspaceIndex(0),
m_contextMenuType(ContextMenuNone),
m_resizer(this),
m_drag(false),

4
sdrgui/device/deviceuiset.cpp

@ -47,7 +47,9 @@ @@ -47,7 +47,9 @@
#include "deviceuiset.h"
DeviceUISet::DeviceUISet(int deviceSetIndex, DeviceSet *deviceSet)
DeviceUISet::DeviceUISet(int deviceSetIndex, DeviceSet *deviceSet) :
m_selectedDeviceSequence(0),
m_selectedDeviceItemImdex(0)
{
m_spectrum = new GLSpectrum();
m_spectrum->setIsDeviceSpectrum(true);

1
sdrgui/feature/featuregui.cpp

@ -41,6 +41,7 @@ @@ -41,6 +41,7 @@
FeatureGUI::FeatureGUI(QWidget *parent) :
WorkspaceWindow(parent),
m_feature(nullptr),
m_featureIndex(0),
m_contextMenuType(ContextMenuNone),
m_resizer(this),

1
sdrgui/gui/basicchannelsettingsdialog.cpp

@ -32,6 +32,7 @@ BasicChannelSettingsDialog::BasicChannelSettingsDialog(ChannelMarker* marker, QW @@ -32,6 +32,7 @@ BasicChannelSettingsDialog::BasicChannelSettingsDialog(ChannelMarker* marker, QW
QDialog(parent),
ui(new Ui::BasicChannelSettingsDialog),
m_channelMarker(marker),
m_streamIndex(0),
m_hasChanged(false)
{
ui->setupUi(this);

4
sdrgui/gui/basicfeaturesettingsdialog.cpp

@ -29,6 +29,10 @@ @@ -29,6 +29,10 @@
BasicFeatureSettingsDialog::BasicFeatureSettingsDialog(QWidget *parent) :
QDialog(parent),
ui(new Ui::BasicFeatureSettingsDialog),
m_useReverseAPI(false),
m_reverseAPIPort(0),
m_reverseAPIFeatureSetIndex(0),
m_reverseAPIFeatureIndex(0),
m_hasChanged(false)
{
ui->setupUi(this);

3
sdrgui/gui/configurationsdialog.cpp

@ -29,7 +29,8 @@ @@ -29,7 +29,8 @@
ConfigurationsDialog::ConfigurationsDialog(bool openOnly, QWidget* parent) :
QDialog(parent),
ui(new Ui::ConfigurationsDialog)
ui(new Ui::ConfigurationsDialog),
m_configurations(nullptr)
{
ui->setupUi(this);
if (openOnly)

3
sdrgui/gui/coursedeviationindicator.cpp

@ -24,7 +24,8 @@ @@ -24,7 +24,8 @@
CourseDeviationIndicator::CourseDeviationIndicator(QWidget *parent) :
QWidget(parent),
m_localizerDDM(0.0f),
m_glideSlopeDDM(0.0f)
m_glideSlopeDDM(0.0f),
m_mode(LOC)
{
}

1
sdrgui/gui/devicesetselectiondialog.cpp

@ -30,6 +30,7 @@ DeviceSetSelectionDialog::DeviceSetSelectionDialog(std::vector<DeviceUISet*>& de @@ -30,6 +30,7 @@ DeviceSetSelectionDialog::DeviceSetSelectionDialog(std::vector<DeviceUISet*>& de
ui(new Ui::WorkspaceSelectionDialog),
m_deviceUIs(deviceUIs),
m_channelDeviceSetIndex(channelDeviceSetIndex),
m_selectedDeviceSetIndex(0),
m_hasChanged(false)
{
ui->setupUi(this);

7
sdrgui/gui/featurelayout.cpp

@ -20,8 +20,11 @@ @@ -20,8 +20,11 @@
#include "featurelayout.h"
FeatureLayout::FeatureLayout(QWidget *parent, int margin, int hSpacing, int vSpacing)
: QLayout(parent), m_hSpace(hSpacing), m_vSpace(vSpacing)
FeatureLayout::FeatureLayout(QWidget *parent, int margin, int hSpacing, int vSpacing) :
QLayout(parent),
m_hSpace(hSpacing),
m_vSpace(vSpacing),
m_orientation(Qt::Horizontal)
{
setContentsMargins(margin, margin, margin, margin);
}

9
sdrgui/gui/fftnrdialog.cpp

@ -21,7 +21,14 @@ @@ -21,7 +21,14 @@
FFTNRDialog::FFTNRDialog(QWidget* parent) :
QDialog(parent),
ui(new Ui::FFTNRDialog)
ui(new Ui::FFTNRDialog),
m_scheme(static_cast<FFTNoiseReduction::Scheme>(0)),
m_aboveAvgFactor(0.0f),
m_sigmaFactor(0.0f),
m_nbPeaks(0),
m_alpha(0.0f),
m_flen(0),
m_sampleRate(0)
{
ui->setupUi(this);
}

2
sdrgui/gui/fmpreemphasisdialog.cpp

@ -28,6 +28,8 @@ @@ -28,6 +28,8 @@
FMPreemphasisDialog::FMPreemphasisDialog(float tau, float highFreq, QWidget* parent) :
QDialog(parent),
m_tau(tau),
m_highFreq(highFreq),
ui(new Ui::FMPreemphasisDialog)
{
ui->setupUi(this);

1
sdrgui/gui/glscope.h

@ -131,6 +131,7 @@ private: @@ -131,6 +131,7 @@ private:
ScopeMarker(const ScopeMarker& other) :
m_point(other.m_point),
m_time(other.m_time),
m_value(other.m_value),
m_timeStr(other.m_timeStr),
m_valueStr(other.m_valueStr),
m_timeDeltaStr(other.m_timeDeltaStr),

4
sdrgui/gui/glspectrumview.cpp

@ -1550,7 +1550,7 @@ void GLSpectrumView::paintGL() @@ -1550,7 +1550,7 @@ void GLSpectrumView::paintGL()
glFunctions->glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
QMatrix4x4 spectrogramGridMatrix;
float devicePixelRatio;
float devicePixelRatio = 1.0f;
if (m_display3DSpectrogram)
{
@ -1575,8 +1575,6 @@ void GLSpectrumView::paintGL() @@ -1575,8 +1575,6 @@ void GLSpectrumView::paintGL()
// Temporarily reduce viewport to waterfall area so anything outside is clipped
if (window()->windowHandle()) {
devicePixelRatio = window()->windowHandle()->devicePixelRatio();
} else {
devicePixelRatio = 1.0f;
}
glFunctions->glViewport(0, m_3DSpectrogramBottom*devicePixelRatio, width()*devicePixelRatio, m_waterfallHeight*devicePixelRatio);
m_glShaderSpectrogram.drawSurface(

5
sdrgui/gui/logslider.cpp

@ -28,7 +28,10 @@ @@ -28,7 +28,10 @@
#include "logslider.h"
LogSlider::LogSlider(QWidget *parent) :
QSlider(Qt::Horizontal, parent)
QSlider(Qt::Horizontal, parent),
m_start(0.0),
m_stop(0.0),
m_steps(0.0)
{
QSlider::setRange(0, 1000);
connect(this, &QSlider::valueChanged, this, &LogSlider::handleValueChanged);

2
sdrgui/gui/scaleengine.cpp

@ -422,7 +422,7 @@ void ScaleEngine::reCalcStd() @@ -422,7 +422,7 @@ void ScaleEngine::reCalcStd()
double value2;
int i;
int j;
Tick tick;
Tick tick{};
float pos;
QString str;
QFontMetricsF fontMetrics(m_font);

3
sdrgui/gui/sdrangelsplash.cpp

@ -22,7 +22,8 @@ @@ -22,7 +22,8 @@
#include "sdrangelsplash.h"
SDRangelSplash::SDRangelSplash(const QPixmap& pixmap)
SDRangelSplash::SDRangelSplash(const QPixmap& pixmap) :
alignement(0)
{
int screenWidth = screen()->availableGeometry().width();
QPixmap pm;

3
sdrgui/gui/spectrummeasurements.cpp

@ -197,7 +197,10 @@ SpectrumMeasurements::SpectrumMeasurements(QWidget *parent) : @@ -197,7 +197,10 @@ SpectrumMeasurements::SpectrumMeasurements(QWidget *parent) :
QWidget(parent),
m_measurement(SpectrumSettings::MeasurementPeaks),
m_precision(1),
m_memMask(0),
m_table(nullptr),
m_rowMenu(nullptr),
m_columnMenu(nullptr),
m_peakTable(nullptr),
m_maskTable(nullptr)
{

16
sdrgui/gui/tvscreenanalog.cpp

@ -113,13 +113,21 @@ static const char* fragmentShaderSource = @@ -113,13 +113,21 @@ static const char* fragmentShaderSource =
"}\n";
TVScreenAnalog::TVScreenAnalog(QWidget *parent) :
QOpenGLWidget(parent),
m_shader(nullptr),
QOpenGLWidget(parent),
m_textureLoc1(0),
m_textureLoc2(0),
m_imageWidthLoc(0),
m_imageHeightLoc(0),
m_texelWidthLoc(0),
m_texelHeightLoc(0),
m_vertexAttribIndex(0),
m_texCoordAttribIndex(0),
m_shader(nullptr),
m_vao(nullptr),
m_verticesBuf(nullptr),
m_textureCoordsBuf(nullptr),
m_imageTexture(nullptr),
m_lineShiftsTexture(nullptr)
m_imageTexture(nullptr),
m_lineShiftsTexture(nullptr)
{
setAttribute(Qt::WA_OpaquePaintEvent);
m_isDataChanged = false;

1
sdrgui/gui/workspaceselectiondialog.cpp

@ -27,6 +27,7 @@ WorkspaceSelectionDialog::WorkspaceSelectionDialog(int numberOfWorkspaces, int w @@ -27,6 +27,7 @@ WorkspaceSelectionDialog::WorkspaceSelectionDialog(int numberOfWorkspaces, int w
QDialog(parent),
ui(new Ui::WorkspaceSelectionDialog),
m_numberOfWorkspaces(numberOfWorkspaces),
m_selectedRow(0),
m_hasChanged(false)
{
ui->setupUi(this);

3
sdrgui/mainwindow.cpp

@ -1226,7 +1226,8 @@ void LoadConfigurationFSM::restoreGeometry() @@ -1226,7 +1226,8 @@ void LoadConfigurationFSM::restoreGeometry()
InitFSM::InitFSM(MainWindow *mainWindow, SDRangelSplash *splash, bool loadDefault, bool showConfigs, QObject *parent) :
MainWindowFSM(mainWindow, parent),
m_splash(splash),
m_showConfigs(showConfigs)
m_showConfigs(showConfigs),
m_loadConfigurationFSM(nullptr)
{
// Create FSM
createStates(2);

7
wdsp/TXA.cpp

@ -63,7 +63,12 @@ TXA::TXA( @@ -63,7 +63,12 @@ TXA::TXA(
_out_rate,
_dsp_rate,
_dsp_size
)
),
meter{},
upslew(0),
bps0(nullptr),
bps1(nullptr),
bps2(nullptr)
{
mode = TXA_LSB;
f_low = -5000.0;

8
wdsp/amd.cpp

@ -66,6 +66,12 @@ AMD::AMD @@ -66,6 +66,12 @@ AMD::AMD
omegaN(_omegaN),
tauR(_tauR),
tauI(_tauI),
a{},
b{},
c{},
d{},
dsI(0),
dsQ(0),
sbmode(_sbmode),
levelfade(_levelfade)
{
@ -117,7 +123,7 @@ void AMD::flush() @@ -117,7 +123,7 @@ void AMD::flush()
void AMD::execute()
{
double audio;
double audio = 0.0;
std::array<double, 2> vco;
std::array<double, 2> corr;
double det;

1
wdsp/amsq.cpp

@ -95,6 +95,7 @@ AMSQ::AMSQ ( @@ -95,6 +95,7 @@ AMSQ::AMSQ (
trigger(_trigger),
rate((double) _rate),
avtau(_avtau),
count(0),
tup(_tup),
tdown(_tdown),
tail_thresh(_tail_thresh),

1
wdsp/cfcomp.cpp

@ -252,6 +252,7 @@ CFCOMP::CFCOMP( @@ -252,6 +252,7 @@ CFCOMP::CFCOMP(
out(_out),
fsize(_fsize),
ovrlp(_ovrlp),
mask_ready(0),
rate(_rate),
wintype(_wintype),
comp_method(_comp_method),

6
wdsp/emnr.cpp

@ -419,7 +419,11 @@ EMNR::G::G( @@ -419,7 +419,11 @@ EMNR::G::G(
rate(_rate),
msize(_msize),
mask(_mask),
y(_y)
y(_y),
gain_method(0),
npe_method(0),
ae_run(0),
fileb(nullptr)
{
lambda_y.resize(msize);

2
wdsp/fcurve.cpp

@ -33,7 +33,7 @@ namespace WDSP { @@ -33,7 +33,7 @@ namespace WDSP {
void FCurve::fc_impulse (std::vector<float>& impulse, int nc, float f0, float f1, float g0, float, int curve, float samplerate, float scale, int ctfmode, int wintype)
{
float* A = new float[nc / 2 + 1]; // (float *) malloc0 ((nc / 2 + 1) * sizeof (float));
float* A = new float[nc / 2 + 1]{}; // (float *) malloc0 ((nc / 2 + 1) * sizeof (float));
int i;
float fn, f;
int mid = nc / 2;

1
wdsp/fmsq.cpp

@ -122,6 +122,7 @@ FMSQ::FMSQ( @@ -122,6 +122,7 @@ FMSQ::FMSQ(
pllpole(_pllpole),
avtau(_avtau),
longtau(_longtau),
count(0),
tup(_tup),
tdown(_tdown),
tail_thresh(_tail_thresh),

7
wdsp/nbp.cpp

@ -41,7 +41,9 @@ namespace WDSP { @@ -41,7 +41,9 @@ namespace WDSP {
* *
********************************************************************************************************/
NOTCHDB::NOTCHDB(int _master_run, int _maxnotches)
NOTCHDB::NOTCHDB(int _master_run, int _maxnotches) :
tunefreq(0),
shift(0)
{
master_run = _master_run;
maxnotches = _maxnotches;
@ -433,7 +435,8 @@ NBP::NBP( @@ -433,7 +435,8 @@ NBP::NBP(
flow(_flow),
fhigh(_fhigh),
maxpb(_maxpb),
notchdb(_notchdb)
notchdb(_notchdb),
hadnotch(0)
{
bplow.resize(maxpb);
bphigh.resize(maxpb);

17
wdsp/nob.cpp

@ -96,8 +96,23 @@ NOB::NOB ( @@ -96,8 +96,23 @@ NOB::NOB (
hangslewtime(_hangslewtime),
hangtime(_hangtime),
max_imp_seq_time(_max_imp_seq_time),
filterlen(0),
backtau(_backtau),
threshold(_threshold)
threshold(_threshold),
time(0),
blank_count(0),
I1(0),
Q1(0),
I2(0),
Q2(0),
I(0),
Q(0),
Ilast(0),
Qlast(0),
deltaI(0),
deltaQ(0),
Inext(0),
Qnext(0)
{
dline_size = (int)(MAX_SAMPLERATE * (
MAX_ADV_SLEW_TIME +

3
wdsp/osctrl.cpp

@ -61,7 +61,8 @@ OSCTRL::OSCTRL( @@ -61,7 +61,8 @@ OSCTRL::OSCTRL(
inbuff(_inbuff),
outbuff(_outbuff),
rate(_rate),
osgain(_osgain)
osgain(_osgain),
env_out(0)
{
bw = 3000.0;
calc();

1
wdsp/siphon.cpp

@ -75,6 +75,7 @@ SIPHON::SIPHON( @@ -75,6 +75,7 @@ SIPHON::SIPHON(
insize(_insize),
in(_in),
sipsize(_sipsize), // NOTE: sipsize MUST BE A POWER OF TWO!!
outsize(0),
fftsize(_fftsize),
specmode(_specmode)
{

3
wdsp/snotch.cpp

@ -69,7 +69,8 @@ SNOTCH::SNOTCH( @@ -69,7 +69,8 @@ SNOTCH::SNOTCH(
out(_out),
rate(_rate),
f(_f),
bw(_bw)
bw(_bw),
x0(0)
{
calc();
}

1
wdsp/speak.cpp

@ -141,6 +141,7 @@ SPEAK::SPEAK( @@ -141,6 +141,7 @@ SPEAK::SPEAK(
rate(_rate),
f(_f),
bw(_bw),
cbw(0.0),
gain(_gain),
nstages(_nstages),
design(_design)

3
wdsp/unit.cpp

@ -40,7 +40,8 @@ Unit::Unit( @@ -40,7 +40,8 @@ Unit::Unit(
in_rate{_in_rate},
out_rate(_out_rate),
dsp_rate(_dsp_rate),
dsp_size(_dsp_size)
dsp_size(_dsp_size),
state(0)
{
if (_in_rate >= _dsp_rate)
dsp_insize = _dsp_size * (_in_rate / _dsp_rate);

5
wdsp/wcpAGC.cpp

@ -94,6 +94,11 @@ WCPAGC::WCPAGC( @@ -94,6 +94,11 @@ WCPAGC::WCPAGC(
fixed_gain(_fixed_gain),
max_input(_max_input),
out_targ(_out_targ),
gain(0),
ring{},
abs_ring{},
out_sample{},
abs_out_sample(0),
tau_fast_backaverage(_tau_fast_backaverage),
tau_fast_decay(_tau_fast_decay),
pop_ratio(_pop_ratio),

Loading…
Cancel
Save