From ff498fa68f2362a54975f00de8f2de483d4ca767 Mon Sep 17 00:00:00 2001 From: Robin Getz Date: Mon, 26 Oct 2026 17:34:29 -0400 Subject: [PATCH] demodmeshtastic: Initialize network manager before settings Allocate QNetworkAccessManager in the constructor initializer list so applySettings() cannot access it before initialization. Identified by Coverity. Signed-off-by: Robin Getz --- plugins/channelrx/demodmeshtastic/meshtasticdemod.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/channelrx/demodmeshtastic/meshtasticdemod.cpp b/plugins/channelrx/demodmeshtastic/meshtasticdemod.cpp index 52b140f76..0ae5aefcc 100644 --- a/plugins/channelrx/demodmeshtastic/meshtasticdemod.cpp +++ b/plugins/channelrx/demodmeshtastic/meshtasticdemod.cpp @@ -82,14 +82,14 @@ MeshtasticDemod::MeshtasticDemod(DeviceAPI* deviceAPI) : m_lastMsgHeaderParityStatus(0), m_lastMsgPayloadCRC(false), m_lastMsgPayloadParityStatus(0), - m_udpSink(this, 256) + m_udpSink(this, 256), + m_networkManager(new QNetworkAccessManager()) { setObjectName(m_channelId); applySettings(m_settings, true); m_deviceAPI->addChannelSink(this); m_deviceAPI->addChannelSinkAPI(this); - m_networkManager = new QNetworkAccessManager(); QObject::connect( this,