Browse Source

audiocompressorsnd : Initialize AudioCompressorSnd members

Initialize all AudioCompressorSnd data members in the constructor so
the compressor state and audio buffers have defined values before use.
This prevents undefined behavior from reading uninitialized member
variables.

Found by cppcheck (uninitMemberVar).

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 2 months ago
parent
commit
0639ff2467
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 20
      sdrbase/audio/audiocompressorsnd.cpp

20
sdrbase/audio/audiocompressorsnd.cpp

@ -25,7 +25,25 @@ @@ -25,7 +25,25 @@
#include "audiocompressorsnd.h"
AudioCompressorSnd::AudioCompressorSnd()
AudioCompressorSnd::AudioCompressorSnd() :
m_rate(0.0f),
m_pregain(0.0f),
m_threshold(0.0f),
m_knee(0.0f),
m_ratio(0.0f),
m_attack(0.0f),
m_release(0.0f),
m_predelay(0.0f),
m_releasezone1(0.0f),
m_releasezone2(0.0f),
m_releasezone3(0.0f),
m_releasezone4(0.0f),
m_postgain(0.0f),
m_wet(0.0f),
m_compressorState{},
m_storageBuffer{},
m_processedBuffer{},
m_sampleIndex(0)
{
m_sampleIndex = 0;
std::fill(m_processedBuffer, m_processedBuffer+AUDIOCOMPRESSORSND_SF_COMPRESSOR_CHUNKSIZE, 0.0f);

Loading…
Cancel
Save