Browse Source

demoddrm: Remove redundant reverse API port bounds

Resolve GCC -Wtype-limits warnings by removing upper-bound
comparisons that are always true or false for uint16_t.
The port's type already enforces the maximum value of 65535;
validation of wider input values remains in place before casting.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 1 month ago
parent
commit
27dfe09bb8
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 4
      plugins/channelrx/demoddrm/drmdemodsettings.cpp

4
plugins/channelrx/demoddrm/drmdemodsettings.cpp

@ -106,7 +106,7 @@ void DRMDemodSettings::sanitize() @@ -106,7 +106,7 @@ void DRMDemodSettings::sanitize()
m_volume = std::clamp(m_volume, 0.0f, 10.0f);
m_streamIndex = std::max(m_streamIndex, 0);
if (m_reverseAPIPort <= 1023 || m_reverseAPIPort > 65535) {
if (m_reverseAPIPort <= 1023) {
m_reverseAPIPort = 8888;
}
@ -261,7 +261,7 @@ void DRMDemodSettings::applySettings(const QStringList& settingsKeys, const DRMD @@ -261,7 +261,7 @@ void DRMDemodSettings::applySettings(const QStringList& settingsKeys, const DRMD
}
if (settingsKeys.contains("reverseAPIPort"))
{
m_reverseAPIPort = settings.m_reverseAPIPort > 1023 && settings.m_reverseAPIPort < 65536
m_reverseAPIPort = settings.m_reverseAPIPort > 1023
? settings.m_reverseAPIPort : 8888;
}
if (settingsKeys.contains("reverseAPIDeviceIndex")) {

Loading…
Cancel
Save