Browse Source

wsspectrum: Avoid overwriting existing WebSocket server

Check for an existing QWebSocketServer before creating a new one.
Leave an already-listening server untouched and clean up an existing
non-listening server before replacing it.

This resolves the cppcheck possible leak warning caused by overwriting
m_webSocketServer without deallocating the previous object.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 2 months ago
parent
commit
3f4a948595
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 11
      sdrbase/websockets/wsspectrum.cpp

11
sdrbase/websockets/wsspectrum.cpp

@ -47,6 +47,17 @@ WSSpectrum::~WSSpectrum() @@ -47,6 +47,17 @@ WSSpectrum::~WSSpectrum()
void WSSpectrum::openSocket()
{
if (m_webSocketServer)
{
if (m_webSocketServer->isListening())
{
qDebug() << "WSSpectrum::openSocket: invoked while spectrum server already listening at "
<< m_listeningAddress.toString() << " on port " << m_port;
return;
}
closeSocket();
}
m_webSocketServer = new QWebSocketServer(
QStringLiteral("Spectrum Server"),
QWebSocketServer::NonSecureMode,

Loading…
Cancel
Save