Browse Source

sdrbase/util: Handle unknown replies in downloadFinished()

Fix Coverity CID 652510 by handling replies missing from
m_downloads. This error case could cause an invalid index
into m_filenames. Log a warning, schedule the reply for
deletion, and return.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.1.0
Robin Getz 4 weeks ago
parent
commit
cae296d8e3
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 5
      sdrbase/util/httpdownloadmanager.cpp

5
sdrbase/util/httpdownloadmanager.cpp

@ -123,6 +123,11 @@ void HttpDownloadManager::downloadFinished(QNetworkReply *reply) @@ -123,6 +123,11 @@ void HttpDownloadManager::downloadFinished(QNetworkReply *reply)
{
QString url = reply->url().toEncoded().constData();
int idx = m_downloads.indexOf(reply);
if (idx < 0) {
qWarning("HttpDownloadManager::downloadFinished: reply not found in downloads");
reply->deleteLater();
return;
}
QString filename = m_filenames[idx];
bool success = false;
bool retry = false;

Loading…
Cancel
Save