Browse Source

sdrbase/channel: Guard against null Web API error messages

Fix Coverity CIDs 652172, 652242, 652256, 652288, 652572, 652666, and
652679 by checking error message pointers before dereferencing them.
Use "Unknown error" when no message is available. Also use Printable for
the successful channel setting debug log.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.1.0
Robin Getz 4 weeks ago
parent
commit
cdfe0a7130
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 24
      sdrbase/channel/channelwebapiutils.cpp

24
sdrbase/channel/channelwebapiutils.cpp

@ -397,8 +397,9 @@ bool ChannelWebAPIUtils::setCenterFrequency(unsigned int deviceIndex, double fre @@ -397,8 +397,9 @@ bool ChannelWebAPIUtils::setCenterFrequency(unsigned int deviceIndex, double fre
}
else
{
QString *message = errorResponse2.getMessage();
qWarning("ChannelWebAPIUtils::setCenterFrequency: set device frequency error %d: %s",
httpRC, qPrintable(*errorResponse2.getMessage()));
httpRC, message ? qPrintable(*message) : "Unknown error");
return false;
}
}
@ -1444,8 +1445,9 @@ bool ChannelWebAPIUtils::patchDeviceSetting(unsigned int deviceIndex, const QStr @@ -1444,8 +1445,9 @@ bool ChannelWebAPIUtils::patchDeviceSetting(unsigned int deviceIndex, const QStr
}
else
{
QString *message = errorResponse2.getMessage();
qWarning("ChannelWebAPIUtils::patchDeviceSetting: set device setting error %d: %s",
httpRC, qPrintable(*errorResponse2.getMessage()));
httpRC, message ? qPrintable(*message) : "Unknown error");
return false;
}
}
@ -1501,8 +1503,9 @@ bool ChannelWebAPIUtils::patchDeviceSetting(unsigned int deviceIndex, const QStr @@ -1501,8 +1503,9 @@ bool ChannelWebAPIUtils::patchDeviceSetting(unsigned int deviceIndex, const QStr
}
else
{
QString *message = errorResponse2.getMessage();
qWarning("ChannelWebAPIUtils::patchDeviceSetting: set device setting error %d: %s",
httpRC, qPrintable(*errorResponse2.getMessage()));
httpRC, message ? qPrintable(*message) : "Unknown error");
return false;
}
}
@ -1550,8 +1553,9 @@ bool ChannelWebAPIUtils::patchFeatureSetting(unsigned int featureSetIndex, unsig @@ -1550,8 +1553,9 @@ bool ChannelWebAPIUtils::patchFeatureSetting(unsigned int featureSetIndex, unsig
}
else
{
QString *message = errorResponse2.getMessage();
qWarning("ChannelWebAPIUtils::patchFeatureSetting: set feature setting %s to %s error %d: %s",
qPrintable(setting), qPrintable(value), httpRC, qPrintable(*errorResponse2.getMessage()));
qPrintable(setting), qPrintable(value), httpRC, message ? qPrintable(*message) : "Unknown error");
return false;
}
}
@ -1599,8 +1603,9 @@ bool ChannelWebAPIUtils::patchFeatureSetting(unsigned int featureSetIndex, unsig @@ -1599,8 +1603,9 @@ bool ChannelWebAPIUtils::patchFeatureSetting(unsigned int featureSetIndex, unsig
}
else
{
QString *message = errorResponse2.getMessage();
qWarning("ChannelWebAPIUtils::patchFeatureSetting: set feature setting %s to %f error %d: %s",
qPrintable(setting), value, httpRC, qPrintable(*errorResponse2.getMessage()));
qPrintable(setting), value, httpRC, message ? qPrintable(*message) : "Unknown error");
return false;
}
}
@ -1680,8 +1685,9 @@ bool ChannelWebAPIUtils::patchFeatureSetting(unsigned int featureSetIndex, unsig @@ -1680,8 +1685,9 @@ bool ChannelWebAPIUtils::patchFeatureSetting(unsigned int featureSetIndex, unsig
}
else
{
QString *message = errorResponse2.getMessage();
qWarning("ChannelWebAPIUtils::patchFeatureSetting: set feature setting %s error %d: %s",
qPrintable(setting), httpRC, qPrintable(*errorResponse2.getMessage()));
qPrintable(setting), httpRC, message ? qPrintable(*message) : "Unknown error");
return false;
}
}
@ -1720,8 +1726,9 @@ bool ChannelWebAPIUtils::patchChannelSetting(ChannelAPI *channel, const QString @@ -1720,8 +1726,9 @@ bool ChannelWebAPIUtils::patchChannelSetting(ChannelAPI *channel, const QString
}
else
{
QString *message = errorResponse2.getMessage();
qWarning("ChannelWebAPIUtils::patchChannelSetting: set feature setting %s to %s error %d: %s",
qPrintable(setting), qPrintable(value.toString()), httpRC, qPrintable(*errorResponse2.getMessage()));
qPrintable(setting), qPrintable(value.toString()), httpRC, message ? qPrintable(*message) : "Unknown error");
return false;
}
}
@ -1834,8 +1841,9 @@ bool ChannelWebAPIUtils::patchChannelSetting(unsigned int deviceSetIndex, unsign @@ -1834,8 +1841,9 @@ bool ChannelWebAPIUtils::patchChannelSetting(unsigned int deviceSetIndex, unsign
}
else
{
QString *message = errorResponse2.getMessage();
qWarning("ChannelWebAPIUtils::patchChannelSetting: set channel setting error %d: %s",
httpRC, qPrintable(*errorResponse2.getMessage()));
httpRC, message ? qPrintable(*message) : "Unknown error");
return false;
}
}

Loading…
Cancel
Save