Browse Source

aprs : Initialize packet decoding state

Initialize APRS packet fields and telemetry buffers so a default-constructed
packet has defined values for decoded position, weather, station, telemetry,
and other optional data. This prevents undefined behavior when optional
fields are accessed before their corresponding presence flags are set.

Found by cppcheck (uninitMemberVar).

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.0.0
Robin Getz 2 months ago
parent
commit
db9bde9619
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 51
      sdrbase/util/aprs.h

51
sdrbase/util/aprs.h

@ -175,45 +175,96 @@ struct SDRBASE_API APRSPacket { @@ -175,45 +175,96 @@ struct SDRBASE_API APRSPacket {
bool decode(AX25Packet packet);
APRSPacket() :
m_utc(false),
m_hasTimestamp(false),
m_latitude(0.0f),
m_longitude(0.0f),
m_hasPosition(false),
m_altitudeFt(0.0f),
m_hasAltitude(false),
m_symbolTable(0),
m_symbolCode(0),
m_hasSymbol(false),
m_course(0),
m_speed(0),
m_hasCourseAndSpeed(false),
m_powerWatts(0),
m_antennaHeightFt(0),
m_antennaGainDB(0),
m_hasStationDetails(false),
m_radioRangeMiles(0),
m_hasRadioRange(false),
m_dfStrength(0),
m_dfHeightFt(0),
m_dfGainDB(0),
m_hasDf(false),
m_objectLive(false),
m_objectKilled(false),
m_windDirection(0),
m_hasWindDirection(false),
m_windSpeed(0),
m_hasWindSpeed(false),
m_gust(0),
m_hasGust(false),
m_temp(0),
m_hasTemp(false),
m_rainLastHr(0),
m_hasRainLastHr(false),
m_rainLast24Hrs(0),
m_hasRainLast24Hrs(false),
m_rainSinceMidnight(0),
m_hasRainSinceMidnight(false),
m_humidity(0),
m_hasHumidity(false),
m_barometricPressure(0),
m_hasBarometricPressure(false),
m_luminosity(0),
m_hasLuminsoity(false),
m_snowfallLast24Hrs(0),
m_hasSnowfallLast24Hrs(false),
m_rawRainCounter(0),
m_hasRawRainCounter(false),
m_radiationLevel(0),
m_hasRadiationLevel(false),
m_floodLevel(0),
m_hasFloodLevel(false),
m_batteryVolts(0),
m_hasBatteryVolts(false),
m_hasWeather(false),
m_stormDirection(0),
m_stormSpeed(0),
m_stormSustainedWindSpeed(0),
m_stormPeakWindGusts(0),
m_stormCentralPresure(0),
m_stormRadiusHurricanWinds(0),
m_stormRadiusTropicalStormWinds(0),
m_stormRadiusWholeGail(0),
m_hasStormRadiusWholeGail(false),
m_hasStormData(false),
m_beamHeading(0),
m_beamPower(0),
m_hasBeam(false),
m_hasStatus(false),
m_hasMessage(false),
m_telemetryCoefficientsA{},
m_telemetryCoefficientsB{},
m_telemetryCoefficientsC{},
m_hasTelemetryCoefficients(0),
m_telemetryBitSense{},
m_hasTelemetryBitSense(false),
m_seqNo(0),
m_hasSeqNo(false),
m_a1(0),
m_a1HasValue(false),
m_a2(0),
m_a2HasValue(false),
m_a3(0),
m_a3HasValue(false),
m_a4(0),
m_a4HasValue(false),
m_a5(0),
m_a5HasValue(false),
m_b{},
m_bHasValue(false),
m_hasTelemetry(false)
{

Loading…
Cancel
Save