Browse Source

demodmeshtastic: Initialize network manager before settings

Allocate QNetworkAccessManager in the constructor initializer list
so applySettings() cannot access it before initialization.

Identified by Coverity.

Signed-off-by: Robin Getz <rgetz503@gmail.com>
chirpmodem-v8.1.0
Robin Getz 4 weeks ago
parent
commit
ff498fa68f
No known key found for this signature in database
GPG Key ID: 51C7231FFED0E060
  1. 4
      plugins/channelrx/demodmeshtastic/meshtasticdemod.cpp

4
plugins/channelrx/demodmeshtastic/meshtasticdemod.cpp

@ -82,14 +82,14 @@ MeshtasticDemod::MeshtasticDemod(DeviceAPI* deviceAPI) : @@ -82,14 +82,14 @@ MeshtasticDemod::MeshtasticDemod(DeviceAPI* deviceAPI) :
m_lastMsgHeaderParityStatus(0),
m_lastMsgPayloadCRC(false),
m_lastMsgPayloadParityStatus(0),
m_udpSink(this, 256)
m_udpSink(this, 256),
m_networkManager(new QNetworkAccessManager())
{
setObjectName(m_channelId);
applySettings(m_settings, true);
m_deviceAPI->addChannelSink(this);
m_deviceAPI->addChannelSinkAPI(this);
m_networkManager = new QNetworkAccessManager();
QObject::connect(
this,

Loading…
Cancel
Save