New channel Tx plugin modchirpmodem, built on libchirpmodem (format v1),
modelled on modpacket: plugin, settings, baseband, source, GUI, web API
adapter, readme.
- A transmission is the message's frames, separated by a gap, then a CW ID
with the source callsign. It is generated in full on a one-thread
generator pool, never on the DSP thread, and posted back to the baseband;
the source plays it out at the channel rate. A result made for an old
channel rate or offset is generated again; one on air when the rate or
offset changes is cut off and reported.
- Policy is libchirpmodem's: a licensed frame without a source callsign is
refused (EPOLICY) and CW ID above 20 WPM is rejected; no encryption
option. CW ID can be turned off in the licensed profile, with a warning in
the GUI and the report. The unlicensed profile is shown in red.
- Settings: SF, BW, payload mode, profile, src, dst, message, repeat, gap,
amplitude, CW ID and its speed. The GUI shows airtime per frame and the
largest body that fits (chirpmodem_frame_seconds, chirpmodem_max_body).
- Web API / MCP: ChirpModemMod.yaml (settings, report, actions), SWG
classes, ChannelSettings/Report/Actions and model factory entries cloned
from PacketMod (plain setters, safe in the request mapper's reset lists),
webapiutils, webapirequestmapper, webapi.qrc. Action {"tx": 1} with
optional src, dst and message for one transmission.
- Channelizer asked for 4 x BW, as chirpmodem_tx_new needs fs >= 2.2 x
(BW/2 + |IF|) and the channelizer leaves a residual offset.
Verified: FileOutput -> cm_rx 3/3 frames, +17.4 dB, 0.0 Hz; FileOutput ->
FileInput -> demodchirpmodem 3/3 in get_packets; over the air (Pluto at
-30 dB through 40 dB to an RTL-SDR, 223.58 MHz) 15/15 frames received by
demodchirpmodem, matching cm_rx on SDRangel's recording of the same signal
(+17.0 dB, -2713 Hz).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
New channel Rx plugin demodchirpmodem, built on libchirpmodem (format v1),
modelled on demodselcal: plugin, settings, baseband, sink, GUI, web API
adapter, readme. Rx only.
- The channel is decimated to at least 2 x BW; the library is given the
delivered rate and the signal's residual offset in it (if_offset).
- The chirpmodem_rx handle lives in the sink and is used only on the
baseband thread under the baseband mutex. Settings changes mark it stale;
it is rebuilt once per message, never during chirpmodem_rx_push().
- Frames are copied in the callback and posted to the channel, which
forwards them to the GUI and publishes OK frames (whole MAC frame) on the
"packets" pipe.
- GUI: SF, BW, effort, auto effort, report failures, max bytes; frames table
(UTC, status, profile, src, dst, SNR, offset Hz/ppm, mode, length, text,
hex) with licensed-profile policy flag; channel spectrum.
- libchirpmodem found with find_package(chirpmodem 0.1 REQUIRED), hint
CHIRPMODEM_DIR or ~/.local; linked statically. Builds in SERVER_MODE.
Web API / MCP support:
- ChirpModemDemod.yaml (settings and report), SWG model classes, entries
in SWGChannelSettings/SWGChannelReport/SWGModelFactory, webapiutils,
webapirequestmapper and webapi.qrc.
- MCP data feed: listen to sdrangel.channel.chirpmodemdemod and decode the
MAC frame (flags, base-40 callsigns, body) for get_packets.
Verified on the 2026-10-23 OTA capture (ota.cu8 -> .sdriq, FileInput):
49/49 frames, identical to cm_rx in order, source and body; last-frame SNR
and offset match (-10.1 dB, -2651.5 Hz, -11.86 ppm).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
writeData() runs on the audio input thread and iterates m_audioFifos
without a lock, while addFifo()/removeFifo() are called from other
threads. A modulator with audio input (e.g. SSB Mod) removes and re-adds
its FIFO each time it starts, so starting a Tx device while audio is
flowing could crash in AudioFifo::write() (SIGSEGV in
QBasicMutex::lockInternal) when the list changed under the iteration.
Keying the transmitter often (e.g. FT8 via WSJT-X) hit it within hours.
Protect the list with its own mutex, held only for the list operations.
m_mutex is left alone, so this does not bring back the lockups the
commented out lock in writeData() was removed for.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Exporting opened the file ReadWrite without truncation, so exporting over
a longer earlier export left its tail in the file and the import then
failed with "Cannot deserialize configuration from file".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Explicitly delete the copy constructor and copy assignment operator for
UDPSinkUtil to prevent accidental duplication of its socket ownership.
The destructor deletes m_socket. A shallow copy would leave multiple
instances referencing the same socket, potentially causing double
deletion and invalid socket access.
Since UDPSinkUtil owns its socket, prohibit copying and assignment at
compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
DoubleBufferFIFO to prevent accidental duplication of its data buffer.
The destructor deletes m_data with delete[]. A shallow copy would cause
multiple instances to own the same buffer, potentially resulting in
double deletion and memory corruption.
Since DoubleBufferFIFO manages its buffer directly, prohibit copying and
assignment at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
FilterStage to prevent accidental duplication of its filter state.
Copying a filter stage could duplicate internal processing state and
resource references, potentially causing incorrect channelization behavior
or resource-management problems.
Since FilterStage is not intended to be copied or assigned, prohibit
both operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
IIRFilter to prevent accidental duplication of filter state.
Copying an IIRFilter instance could duplicate internal filter state and
coefficient references, potentially causing incorrect processing or
resource-management problems.
Since IIRFilter is not intended to be copied or assigned, prohibit both
operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
FFTNoiseReduction to prevent accidental duplication of its noise-reduction
state.
Copying an FFTNoiseReduction instance could duplicate internal processing
state or resource references, potentially causing incorrect behavior or
resource-management problems.
Since FFTNoiseReduction is not intended to be copied or assigned,
prohibit both operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
sfft to prevent accidental duplication of FFT processing state.
Copying an FFT instance could duplicate internal state or resource
references, potentially causing incorrect processing or resource-management
problems.
Since sfft is not intended to be copied or assigned, prohibit both
operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
FilterStage to prevent accidental duplication of its filter state.
Copying a filter stage could duplicate internal processing state and
resources, potentially causing incorrect channelization behavior or
resource-management problems.
Since FilterStage is not intended to be copied or assigned, prohibit
both operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
CTCSSDetector to prevent accidental duplication of its detector state.
Copying could duplicate internal detection state and coefficients, leading
to unintended behavior if instances are expected to maintain independent
processing state.
Since CTCSSDetector is not intended to be copied or assigned, prohibit
both operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
AFSquelch to prevent accidental duplication of its DSP state.
The implicitly generated copy operations could duplicate internal filter
state and coefficients, potentially causing unintended behavior if the
instances are expected to maintain independent processing state.
Since AFSquelch is not intended to be copied or assigned, prohibit both
operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
DeviceSet, which manages device and channel state that should not be
duplicated through implicit shallow copies.
The implicitly generated copy operations could duplicate internal state and
resource references, potentially causing inconsistent device state or
invalid resource ownership.
Since DeviceSet is not intended to be copied or assigned, prohibit both
operations at compile time to prevent unsafe duplication.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Delete the copy constructor and copy assignment operator to prevent
shallow copies of the dynamically allocated m_superBlocks array, which
could lead to double deletion.
Add a move constructor that transfers ownership of m_superBlocks and
nulls the source pointer, allowing std::vector<RemoteDataFrame> to
relocate elements safely during resize.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
AudioNetSink, which manages audio output and network resources that should
not be duplicated through implicit shallow copies.
The implicitly generated copy operations could leave multiple AudioNetSink
instances referring to the same resources, potentially causing invalid
ownership or double deletion.
Since AudioNetSink is not intended to be copied or assigned, prohibit both
operations at compile time to prevent unsafe resource ownership.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Fix TX scaling bug that was costing 10dB of output power at max gain.
Improve performance on Windows to reduce overruns at high sample rates.
Add underrun stats.
Display temperature.
Improve error handling.
Move setting device settings off GUI thread. For #1522
Add a terminating LF to tracked text files that were missing a
newline at end of file. This avoids Codacy whitespace failures and
ensures text files conform to the repository line-ending policy.
Affected files were identified and fixed with the following script.
It checks all tracked files against .gitattributes, skips files marked
as binary or -text, and reports the final 32 bytes of any non-empty text
file that does not end with LF before adding the missing newline.
git ls-files -z |
while IFS= read -r -d '' f; do
attr=$(git check-attr text -- "$f")
case "$attr" in
"$f: text: unset"|"$f: text: unspecified")
continue
;;
esac
[ -f "$f" ] || continue
[ -s "$f" ] || continue
[ "$(tail -c 1 -- "$f" | od -An -t x1 | tr -d ' \n')" = "0a" ] || {
printf '%s\n' "$f"
tail -c 32 -- "$f" | hexdump -C
printf '\n' >> "$f"
}
done
Signed-off-by: Robin Getz <rgetz503@gmail.com>