Resolve GCC -Wreorder by moving m_spectrumBinHz before
m_autoUnlockedSamples in the constructor initializer list to
match declaration order in the header. C++ initializes members
in declaration order regardless of initializer list order, so
keeping the list aligned avoids misleading initialization
sequences and helps prevent future initialization bugs.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Resolve GCC -Wtype-limits warnings by removing upper-bound
comparisons that are always true or false for uint16_t.
The port's type already enforces the maximum value of 65535;
validation of wider input values remains in place before casting.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Avoid copying the UHD shared-pointer handle when enabling automatic
master clock rate selection. Passing the handle by const reference
reduces unnecessary reference-count operations while preserving
access to the underlying USRP device.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Use std::move when initializing the restoreAutoTickRate guard to
avoid an unnecessary copy of properties. Include utility explicitly
for std::move and make ownership transfer intent clear, reducing
overhead during USRP device initialization.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Remove the unused eta variable in Receiver::decodeFrame().
The value returned by bitsPerCell() was never used, so its
calculation is unnecessary and removing it eliminates the
unused-variable compiler warning without changing behavior.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Resolve the compiler warning for the unused frequencyHz parameter
in processAcquisitionSample(). Use Q_UNUSED to explicitly document
that the parameter is intentionally unused without changing behavior.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Resolve GCC -Wmissing-field-initializers by explicitly initializing
the onEdit callback to an empty std::function. This ensures the
callback starts in a defined empty state and avoids relying on
implicit aggregate initialization behavior.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Resolve GCC -Wsign-compare by matching the loop index type to
the unsigned size returned by the container. This avoids
signed/unsigned comparison errors and potential incorrect loop
bounds when processing sample buffers.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Run the Windows build to completion before invoking the CPack package
target. This avoids a file-access race in which fixup_bundle() attempts
to inspect runtime DLLs in the build/bin directory while DLL-copy
commands may still be running.
The separate steps eliminate the observed libsigmf.dll access failure
with Ninja. The underlying build-ordering issue has not yet been
identified.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Add a shared Git hook to reject trailing whitespace in staged changes.
Document how developers enable the hook locally. Keep the GitHub
Actions check as a server-side safeguard for pull requests.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Reject trailing whitespace, including in new files and lines.
Trailing spaces and tabs provide no value, can cause
inconsistent rendering, complicate diffs and merges, and
create needless whitespace-only changes in future edits.
Keeping them out makes source files cleaner and reviews
easier.
Use .gitattributes to limit checks to text files.
Fetch full history to make the PR base and head commits available.
Signed-off-by: Robin Getz <rgetz503@gmail.com>