Renaming a collapsed preset or configuration group lost its collapsed
state and left a stale entry under the old name. Deleting a group left a
stale entry too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Device Set Presets and Configurations dialogs expanded every group each
time they were opened. With many groups, finding a preset means scrolling
through the whole list.
Remember which groups the user collapses (QSettings keys
presets.collapsed_groups and configurations.collapsed_groups, same mechanism
as graphics.ui_scale_factor) and restore that state when the dialogs are
reopened. The initially selected item is now picked from expanded groups
only, so the selection does not re-expand a collapsed group.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The GUI is set up on the rollup contents widget, so Qt does not
auto-connect the on_meshPreset_currentIndexChanged and
on_meshApply_clicked slots. They were never called: choosing a preset or
clicking Apply had no effect, USER did not enable the manual LoRa
controls and the preset went back to the saved EU_NARROW on the next
settings refresh. Connect them explicitly as the MeshCore modulator and
Meshtastic demodulator already do.
Fixes#2874
setValue() formatted the new text before clamping the value, so a value
above the maximum produced a text with more digits than the dial and the
dial ended up showing the unclamped value. Format the clamped value
instead.
The current and new texts can still differ in length while animating,
for example when setValueRange() changes the number of digits, so only
compare characters that exist in the new text.
Fixes#2997
Explicitly delete the copy constructor and copy assignment operator for
Unit to prevent accidental duplication of DSP processing state.
Copying a Unit instance could duplicate internal buffer and processing
state, potentially causing incorrect DSP behavior or resource-management
problems.
Since Unit is not intended to be copied or assigned, prohibit both
operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
TVScreenAnalogBuffer to prevent accidental duplication of its buffer.
The destructor deletes m_outOfBoundsLine with delete[]. A shallow copy
would cause multiple instances to own the same array, potentially
resulting in double deletion and memory corruption.
Since TVScreenAnalogBuffer manages this buffer directly, prohibit copying
and assignment at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
UDPSinkUtil to prevent accidental duplication of its socket ownership.
The destructor deletes m_socket. A shallow copy would leave multiple
instances referencing the same socket, potentially causing double
deletion and invalid socket access.
Since UDPSinkUtil owns its socket, prohibit copying and assignment at
compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
DoubleBufferFIFO to prevent accidental duplication of its data buffer.
The destructor deletes m_data with delete[]. A shallow copy would cause
multiple instances to own the same buffer, potentially resulting in
double deletion and memory corruption.
Since DoubleBufferFIFO manages its buffer directly, prohibit copying and
assignment at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
FilterStage to prevent accidental duplication of its filter state.
Copying a filter stage could duplicate internal processing state and
resource references, potentially causing incorrect channelization behavior
or resource-management problems.
Since FilterStage is not intended to be copied or assigned, prohibit
both operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
IIRFilter to prevent accidental duplication of filter state.
Copying an IIRFilter instance could duplicate internal filter state and
coefficient references, potentially causing incorrect processing or
resource-management problems.
Since IIRFilter is not intended to be copied or assigned, prohibit both
operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
FFTNoiseReduction to prevent accidental duplication of its noise-reduction
state.
Copying an FFTNoiseReduction instance could duplicate internal processing
state or resource references, potentially causing incorrect behavior or
resource-management problems.
Since FFTNoiseReduction is not intended to be copied or assigned,
prohibit both operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
sfft to prevent accidental duplication of FFT processing state.
Copying an FFT instance could duplicate internal state or resource
references, potentially causing incorrect processing or resource-management
problems.
Since sfft is not intended to be copied or assigned, prohibit both
operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
FilterStage to prevent accidental duplication of its filter state.
Copying a filter stage could duplicate internal processing state and
resources, potentially causing incorrect channelization behavior or
resource-management problems.
Since FilterStage is not intended to be copied or assigned, prohibit
both operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
CTCSSDetector to prevent accidental duplication of its detector state.
Copying could duplicate internal detection state and coefficients, leading
to unintended behavior if instances are expected to maintain independent
processing state.
Since CTCSSDetector is not intended to be copied or assigned, prohibit
both operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
AFSquelch to prevent accidental duplication of its DSP state.
The implicitly generated copy operations could duplicate internal filter
state and coefficients, potentially causing unintended behavior if the
instances are expected to maintain independent processing state.
Since AFSquelch is not intended to be copied or assigned, prohibit both
operations at compile time.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
DeviceSet, which manages device and channel state that should not be
duplicated through implicit shallow copies.
The implicitly generated copy operations could duplicate internal state and
resource references, potentially causing inconsistent device state or
invalid resource ownership.
Since DeviceSet is not intended to be copied or assigned, prohibit both
operations at compile time to prevent unsafe duplication.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Delete the copy constructor and copy assignment operator to prevent
shallow copies of the dynamically allocated m_superBlocks array, which
could lead to double deletion.
Add a move constructor that transfers ownership of m_superBlocks and
nulls the source pointer, allowing std::vector<RemoteDataFrame> to
relocate elements safely during resize.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
AudioNetSink, which manages audio output and network resources that should
not be duplicated through implicit shallow copies.
The implicitly generated copy operations could leave multiple AudioNetSink
instances referring to the same resources, potentially causing invalid
ownership or double deletion.
Since AudioNetSink is not intended to be copied or assigned, prohibit both
operations at compile time to prevent unsafe resource ownership.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
RTPRawPacket, which represents a received packet and manages resources
that should not be duplicated through implicit shallow copies.
The implicitly generated copy operations could duplicate internal pointers,
leaving multiple RTPRawPacket instances referring to the same resources
and potentially causing invalid ownership or double deletion.
Since RTPRawPacket is not intended to be copied or assigned, prohibit both
operations at compile time to prevent unsafe resource ownership.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
UDPSourceSource, which manages resources that should not be shared through
implicit shallow copies.
The implicitly generated copy operations could leave multiple UDPSourceSource
instances referring to the same resources, potentially causing invalid
ownership or double deletion.
Since UDPSourceSource is not intended to be copied or assigned, prohibit
both operations at compile time to prevent unsafe resource ownership.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
DVBS, which manages resources that should not be shared through implicit
shallow copies.
The implicitly generated copy operations could leave multiple DVBS
instances referring to the same resources, potentially causing invalid
ownership or double deletion.
Since DVBS is not intended to be copied or assigned, prohibit both
operations at compile time to prevent unsafe resource ownership.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
ATVModSource, which manages resources that should not be shared through
implicit shallow copies.
The implicitly generated copy operations could leave multiple ATVModSource
instances referring to the same resources, potentially causing invalid
ownership or double deletion.
Since ATVModSource is not intended to be copied or assigned, prohibit both
operations at compile time, turning potential runtime errors into
compile-time errors.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
WDSPRxSink, which manages resources that should not be shared through
implicit shallow copies.
The implicitly generated copy operations could leave multiple WDSPRxSink
instances referring to the same resources, potentially causing invalid
ownership or double deletion.
Since WDSPRxSink is not intended to be copied or assigned, prohibit both
operations at compile time, turning potential runtime errors into
compile-time errors.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
FileSinkSink, which manages resources that should not be shared through
implicit shallow copies.
The implicitly generated copy operations could leave multiple FileSinkSink
instances referring to the same resources, potentially causing invalid
ownership or double deletion.
Since FileSinkSink is not intended to be copied or assigned, prohibit both
operations at compile time, turning potential runtime errors into
compile-time errors.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
WFMDemodSink, which manages resources that should not be shared through
implicit shallow copies.
The implicitly generated copy operations could leave multiple WFMDemodSink
instances referring to the same resources, potentially causing invalid
ownership or double deletion.
Since WFMDemodSink is not intended to be copied or assigned, prohibit both
operations at compile time, turning potential runtime errors into
compile-time errors.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Explicitly delete the copy constructor and copy assignment operator for
SSBDemodSink, which manages resources that should not be shared through
implicit shallow copies.
The implicitly generated copy operations could leave multiple SSBDemodSink
instances referring to the same resources, potentially causing invalid
ownership or double deletion.
Since SSBDemodSink is not intended to be copied or assigned, prohibit both
operations at compile time, turning potential runtime errors into
compile-time errors.
cppcheck identified the missing copy constructor and assignment operator
with its noCopyConstructor and noOperatorEq warnings.
Signed-off-by: Robin Getz <rgetz503@gmail.com>