Run the Windows build to completion before invoking the CPack package
target. This avoids a file-access race in which fixup_bundle() attempts
to inspect runtime DLLs in the build/bin directory while DLL-copy
commands may still be running.
The separate steps eliminate the observed libsigmf.dll access failure
with Ninja. The underlying build-ordering issue has not yet been
identified.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Add a shared Git hook to reject trailing whitespace in staged changes.
Document how developers enable the hook locally. Keep the GitHub
Actions check as a server-side safeguard for pull requests.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Reject trailing whitespace, including in new files and lines.
Trailing spaces and tabs provide no value, can cause
inconsistent rendering, complicate diffs and merges, and
create needless whitespace-only changes in future edits.
Keeping them out makes source files cleaner and reviews
easier.
Use .gitattributes to limit checks to text files.
Fetch full history to make the PR base and head commits available.
Signed-off-by: Robin Getz <rgetz503@gmail.com>
Renaming a collapsed preset or configuration group lost its collapsed
state and left a stale entry under the old name. Deleting a group left a
stale entry too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Device Set Presets and Configurations dialogs expanded every group each
time they were opened. With many groups, finding a preset means scrolling
through the whole list.
Remember which groups the user collapses (QSettings keys
presets.collapsed_groups and configurations.collapsed_groups, same mechanism
as graphics.ui_scale_factor) and restore that state when the dialogs are
reopened. The initially selected item is now picked from expanded groups
only, so the selection does not re-expand a collapsed group.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The GUI is set up on the rollup contents widget, so Qt does not
auto-connect the on_meshPreset_currentIndexChanged and
on_meshApply_clicked slots. They were never called: choosing a preset or
clicking Apply had no effect, USER did not enable the manual LoRa
controls and the preset went back to the saved EU_NARROW on the next
settings refresh. Connect them explicitly as the MeshCore modulator and
Meshtastic demodulator already do.
Fixes#2874
setValue() formatted the new text before clamping the value, so a value
above the maximum produced a text with more digits than the dial and the
dial ended up showing the unclamped value. Format the clamped value
instead.
The current and new texts can still differ in length while animating,
for example when setValueRange() changes the number of digits, so only
compare characters that exist in the new text.
Fixes#2997